Repository navigation
refactor: slim repository root layout - #179
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @looptroop-ai, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 2 days and 4 hours by commenting @sourcery-ai review. Upgrade to get a review now.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's GuideThe PR reorganizes existing repository content without adding top-level directories: community files, database configs, Docker packaging, and installer sources move into Sequence diagram for the relocated release assetssequenceDiagram
participant Workflow as Release workflow
participant Sources as scripts/install.sh and scripts/install.ps1
participant Manifest as release-manifest.json
participant Assets as release-assets
participant Upload as Artifact upload
Workflow->>Sources: npm run release:manifest
Workflow->>Manifest: Generate release manifest
Workflow->>Assets: cp installers, tarballs, manifest, checksums
Assets->>Upload: Upload staged release-assets directory
Upload-->>Workflow: Published asset names remain install.sh and install.ps1
Sequence diagram for the relocated Docker build contextsequenceDiagram
participant Workflow as CI or release workflow
participant Tar as Build context archive
participant Docker as Docker buildx
participant Image as Container image
Workflow->>Tar: Archive scripts/Dockerfile, package-lock.json, and tarball
Tar->>Docker: docker buildx build -f scripts/Dockerfile
Docker->>Image: Build using repository-root context paths
Image-->>Workflow: Built container image
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
The Dockerfile relocation to scripts/ is implemented correctly and consistently across all workflow files. All path references have been properly updated to scripts/Dockerfile, including the -f flag additions where needed. The changes maintain functionality while improving repository organization.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe repository layout now places installer and Docker sources under ChangesRepository layout relocation
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The layout refactor preserves installer names, release paths, Docker compatibility, and database tooling behavior. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 15 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoSlim repository root while preserving release and container contracts
AI Description
Diagram
High-Level Assessment
Files changed (23)
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 11 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
 |
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Code Review SummaryThis review did not finish. The model reached its output limit before it Previous Review Summaries (2 snapshots, latest commit aaf172e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit aaf172e)Status: No Issues Found | Recommendation: Merge This incremental review covers the changes since commit The test suite was correspondingly updated: No new critical bugs or security vulnerabilities were introduced in these changes. Files Reviewed (6 files)
Previous review (commit afe6c2a)Status: No Issues Found | Recommendation: Merge Files Reviewed (24 files)
|
|
Muse Spark review — findings only (checked against the PR branch
|
|
opencode 1. The workflow itself runs from the dispatch ref (normally Matching the existing fallback style: dockerfile=scripts/Dockerfile
[ -f "${dockerfile}" ] || dockerfile=Dockerfile
context_files=("${dockerfile}" "${TARBALL}")
tar -cf - "${context_files[@]}" | docker buildx build -f "${dockerfile}" \
...
2. Published docs still point Renovate at the repository root
3. Nothing resolves it: every 4. Wrapper comments still read as if the installers sit at the repository root
|
Antigravity — Code Review Findings & Recommendations1.
|
|
Claude Opus 5 — review of 1.
|
|
opencode 1 — Tests that must move with the fix:
2 — The website still points at the old Renovate config path. 3 — |
Review findings — code review of
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 28 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Code review (round 2) —
|
|
Claude Opus 5 — round 2 review of Status of the round-1 findings
On #1: the 2 (still open).
|
|
Muse Spark re-review — full diff re-checked including Verified fixed by
|
Antigravity — Code Review Findings & Recommendations1. File mode regression on
|
|
opencode 1. GitHub reports this PR as CONFLICTING against
|
|
opencode Re-review of 1. Published website docs still say the Renovate config lives in
2. Nothing resolves it: the 3.
4. The basename contract that keeps
5. Stale comments still name the installers without their directory
|
Move community health files and Renovate configuration into .github, database configs into server/db, and the Dockerfile and installer sources into the existing scripts directory. Delete the obsolete tsconfig.node.json and update every script, test, workflow, and live README link that consumed the old paths. Preserve install.sh and install.ps1 as public release asset names, keep Docker builds rooted at the repository context, and stage release assets so downstream verification remains unchanged.
Select the Dockerfile path that exists in the released tag so container republish can repair both pre-layout root Dockerfiles and current scripts/Dockerfile tags. Extend the packaging probe and workflow policy coverage to exercise both layouts, and document the release manifest basename and artifact-root contracts. Record the historical repair guarantee in the Unreleased changelog. The unrelated untracked server/db migration remains unstaged and untouched.
Correct release artifact staging so wildcard uploads restore a flat file set for every downstream verification and publication job, and validate the staged directory against the generated manifest before upload. Keep historical container repairs diagnosable when neither Dockerfile layout exists, and pin the Dockerfile flags and installer Windows-scope paths in tests. Remove the unreachable Drizzle default config, align project database path resolution with the app config, document explicit Drizzle config usage, and add guards for moved root files and package script config paths. Refresh installer path comments and generated copies, and record all cleanup in the changelog.
aaf172e to
e5f5b75
Compare
Code review (round 3) —
|
Antigravity — Code Review (Critical & Major Findings)No major, critical, or blocking issues remain in PR #179 after commit Verification details:
|
|
Claude Opus 5 — round 3 review of The release asset set is written in three places. This commit reconciled two of them.
subject-path: |
looptroop-*.tgz
looptroop-*-bundle.tar.gz
looptroop-*-linux-*.tar.gz
looptroop-*-darwin-*.tar.gz
looptroop-*-win-*.zip
package-lock.json
install.sh
install.ps1
release-manifest.json
checksums.sha256Nothing reconciles that list against the manifest, and nothing asserts it: So a future asset added to Fix. The job downloads the artefact and does nothing else — there is no - name: Download the release artefacts
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
with:
name: release-artefacts
path: release-assets
- name: Attest the release assets
uses: actions/attest-build-provenance@4d101475d8b20a2381f78447822ac1eab6504dd8 # v4.2.2
with:
subject-path: release-assets/*
Verified on 🤖 Generated with Claude Code |
Download the release artifact into a job-local directory and attest its complete contents with a wildcard instead of maintaining a separate filename list. This keeps the verification and publication jobs flat while ensuring future release assets cannot be published without provenance. Add a workflow-policy regression assertion and document the attestation coverage in the Unreleased changelog.
Code Review ✅ Approved🔴 High risk · Release packaging, installer paths, and container workflows broadly alter deployment behavior. Refactors the repository root layout by relocating community files, database configurations, Docker tooling, and installer sources into existing project directories while preserving public release asset names, container build compatibility, and all external contracts. All verification checks passed and no issues were found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 2 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 28 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
1 participant
Summary
.github/,server/db/, andscripts/directories; no new top-level directories are added.tsconfig.node.json.install.shandinstall.ps1, and preserve the repository-root Docker build context throughscripts/Dockerfile.Verification
npm run typechecknpm run lintnpm test— 6,768 passed, 13 skippednpm run buildnpm run verify:packagenpm run installers:checknpm run licenses:checknpm run verify:no-native-addonsnpx drizzle-kit check --config=server/db/app.config.tsnpx drizzle-kit check --config=server/db/project.config.tsgit diff --checkCI was not awaited, per request. This PR is intentionally not merged.
Summary by Sourcery
Slim the repository root layout while preserving installer, container, release, and documentation contracts.
Enhancements:
Build:
CI:
Deployment:
Documentation:
Tests:
Chores:
Summary by CodeRabbit
Changed
Removed
Documentation