refactor: remove @loopback/openapi-v3 from dependencies#5932
Merged
Conversation
5 tasks
raymondfeng
approved these changes
Jul 14, 2020
Contributor
|
Please fix build errors: |
raymondfeng
requested changes
Jul 14, 2020
Contributor
raymondfeng
left a comment
There was a problem hiding this comment.
Please address #5932 (comment)
Member
Author
Weird. |
9576391 to
25bd30b
Compare
Member
Author
|
Managed to reproduce the problem after running @raymondfeng LGTY now? |
raymondfeng
approved these changes
Jul 16, 2020
Import OpenAPI-related helpers from `@loopback/rest` instead. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
25bd30b to
4da80ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import OpenAPI-related helpers from
@loopback/restinstead.See #5692
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈