feat: remove openapi-v3 from apiconnect dependencies#5927
Merged
Conversation
2b21592 to
f4559e0
Compare
raymondfeng
reviewed
Jul 13, 2020
Member
Author
|
@raymondfeng thank you for the comment above. How to move this pull request forward? Are you fine with the proposed approach or would you like me to rework the patch to avoid introduction of peer dependencies? Something else? |
5 tasks
Contributor
|
Here is my personal preference but I won't block you from merging this PR as is.
|
Use `@loopback/rest` to access openapi-related types and helpers. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
f4559e0 to
72ae24c
Compare
Member
Author
That's a good plan 👍 I cannot simply remove @raymondfeng LGTY now? |
2 tasks
raymondfeng
approved these changes
Jul 16, 2020
5 tasks
This was referenced Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
@loopback/restto access openapi-related types and helpers.This pull request is a part of #5692.
BREAKING CHANGE:@loopback/coreand@loopback/restwere moved to peer dependencies, to ensure the extension uses application's version of these modules. If this change breaks your application (which is unlikely), then simply add both@loopback/coreand@loopback/restto your project dependencies.I am observing timeouts when running the tests locally (even on master), I think they are not related to my changes and will rely on CI builds to confirm.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈