fix: parse the process name to get the process type instead of using port count #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to wait until IM PR merged, so I can update the vendor here. |
innobead
previously requested changes
Mar 8, 2024
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
cbdd046
to
54fbf48
Compare
|
Wait for longhorn/go-common-libs#25 |
|
@ChanYiLin any updates? |
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
54fbf48
to
c1277f9
Compare
|
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
c1277f9
to
b59e60b
Compare
fixed. |
Waiting for longhorn/longhorn-instance-manager#407 |
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
b59e60b
to
ab57676
Compare
derekbit
reviewed
Apr 12, 2024
…port count ref: longhorn/longhorn 7393 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
ab57676
to
b249ac6
Compare
derekbit
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#7393
Get the process type by parsing the name instead of using port count.