fix: parse the process name to get the process type instead of using port count #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E testing (-m coretest): |
|
E2E test PASSED |
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
c58f0cc
to
baf9a5c
Compare
innobead
previously requested changes
Mar 8, 2024
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
2 times, most recently
from
84feb41
to
f640a16
Compare
|
Please fix the conflict and then we can move forward. |
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
f640a16
to
087721b
Compare
|
Hi @innobead |
derekbit
reviewed
Apr 11, 2024
derekbit
reviewed
Apr 11, 2024
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
087721b
to
ac28ac5
Compare
derekbit
reviewed
Apr 11, 2024
…port count ref: longhorn/longhorn 7393 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH7393_build_robust_method_to_differentiate_engine_process
branch
from
ac28ac5
to
7b6052a
Compare
derekbit
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#7393
Get the process type by parsing the name instead of using port count.