Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Storage (LEP 20230430) #148

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backupstore.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type Volume struct {
CompressionMethod string `json:",string"`
StorageClassName string `json:",string"`
BackendStoreDriver string `json:",string"`
ObjectStoreBackup string `json:",string"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the value of this property? ObjectStoreBackup seems too general, so not sure what things will be saved here.

}

type Snapshot struct {
Expand All @@ -46,6 +47,7 @@ type Backup struct {
Labels map[string]string
IsIncremental bool
CompressionMethod string
ObjectStoreBackup string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the value of this property?


ProcessingBlocks *ProcessingBlocks

Expand Down
2 changes: 2 additions & 0 deletions deltablock.go
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,7 @@ func performBackup(bsDriver BackupStoreDriver, config *DeltaBackupConfig, delta
backup.CreatedTime = util.Now()
backup.Size = int64(len(backup.Blocks)) * DEFAULT_BLOCK_SIZE
backup.Labels = config.Labels
backup.ObjectStoreBackup = volume.ObjectStoreBackup
backup.IsIncremental = lastBackup != nil

if err := saveBackup(bsDriver, backup); err != nil {
Expand All @@ -554,6 +555,7 @@ func performBackup(bsDriver BackupStoreDriver, config *DeltaBackupConfig, delta
volume.CompressionMethod = config.Volume.CompressionMethod
volume.StorageClassName = config.Volume.StorageClassName
volume.BackendStoreDriver = config.Volume.BackendStoreDriver
volume.ObjectStoreBackup = config.Volume.ObjectStoreBackup

if err := saveVolume(bsDriver, volume); err != nil {
return progress.progress, "", err
Expand Down
2 changes: 2 additions & 0 deletions inspect.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ func fillVolumeInfo(volume *Volume) *VolumeInfo {
BackingImageChecksum: volume.BackingImageChecksum,
StorageClassname: volume.StorageClassName,
BackendStoreDriver: volume.BackendStoreDriver,
ObjectStoreBackup: volume.ObjectStoreBackup,
}
}

Expand All @@ -91,6 +92,7 @@ func fillBackupInfo(backup *Backup, destURL string) *BackupInfo {
Labels: backup.Labels,
IsIncremental: backup.IsIncremental,
CompressionMethod: backup.CompressionMethod,
ObjectStoreBackup: backup.ObjectStoreBackup,
}
}

Expand Down
2 changes: 2 additions & 0 deletions list.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ type VolumeInfo struct {
BackingImageChecksum string
StorageClassname string
BackendStoreDriver string
ObjectStoreBackup string `json:",omitempty"`
}

type BackupInfo struct {
Expand All @@ -46,6 +47,7 @@ type BackupInfo struct {
VolumeSize int64 `json:",string,omitempty"`
VolumeCreated string `json:",omitempty"`
VolumeBackingImageName string `json:",omitempty"`
ObjectStoreBackup string `json:",omitempty"`

Messages map[types.MessageType]string
}
Expand Down