Object Storage (LEP 20230430) #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2023
m-ildefons
force-pushed
the
wip/object-store
branch
from
814b4e5
to
202bdcc
Compare
17 tasks
m-ildefons
changed the title
m-ildefons
force-pushed
the
wip/object-store
branch
from
202bdcc
to
fdcfa1f
Compare
innobead
reviewed
Nov 13, 2023
| @@ -23,6 +23,7 @@ type Volume struct { | |||
| CompressionMethod string `json:",string"` | |||
| StorageClassName string `json:",string"` | |||
| BackendStoreDriver string `json:",string"` | |||
| ObjectStoreBackup string `json:",string"` | |||
There was a problem hiding this comment.
What's the value of this property? ObjectStoreBackup seems too general, so not sure what things will be saved here.
innobead
reviewed
Nov 13, 2023
| @@ -46,6 +47,7 @@ type Backup struct { | |||
| Labels map[string]string | |||
| IsIncremental bool | |||
| CompressionMethod string | |||
| ObjectStoreBackup string | |||
There was a problem hiding this comment.
What's the value of this property?
Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons
force-pushed
the
wip/object-store
branch
from
fdcfa1f
to
9f0433b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of backup functionality for the object store.
The object store consists of a normal longhorn volume and an object storage gateway (s3gw) instance. In case of a backup, the details of the object storage gateway deployment must be backed up as well, to be able to restore the entire object store. Therefore an object store backup carries additional metadata in the form of the deployment details of the object storage gateway.
Related: longhorn/longhorn#6640
Related: longhorn/longhorn-manager#2136
Related: longhorn/longhorn-ui#649
Related: longhorn/longhorn-engine#934
Related: longhorn/longhorn-instance-manager#285
LEP: longhorn/longhorn#5832