update to new shutdown semantics #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure whether this line needs to be changed to |
43 tasks
| @@ -116,7 +115,7 @@ def run(output_queue) | |||
| def server(protocol, output_queue) | |||
| self.send("#{protocol}_listener", output_queue) | |||
| rescue => e | |||
| if @shutdown_requested.false? | |||
| if !stop? | |||
| @logger.warn("syslog listener died", :protocol => protocol, :address => "#{@host}:#{@port}", :exception => e, :backtrace => e.backtrace) | |||
| sleep(5) | |||
There was a problem hiding this comment.
This might need to be updated to use Stud.stoppable_stop { stop? }, what do you think?
There was a problem hiding this comment.
updated to include this (stoppable_sleep)
|
@talevy RE: #21 (comment) I don't think is necessary, however In some plugins I made I changed the infinite loop just to indicate better that this loop will stop some time. |
talevy
force-pushed
the
new_shutdown
branch
from
57ba2c3
to
62c0c04
Compare
|
@purbon updated with your comments! thanks! |
talevy
force-pushed
the
new_shutdown
branch
from
62c0c04
to
862945f
Compare
|
LGTM |
|
Merged sucessfully into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
depends on elastic/logstash#3895 and elastic/logstash-devutils#32.