Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shutdown sequence to use plugin.stop #20

Closed
jsvd opened this issue Sep 11, 2015 · 0 comments
Closed

refactor shutdown sequence to use plugin.stop #20

jsvd opened this issue Sep 11, 2015 · 0 comments
Assignees
@talevy
Labels
shutdown semantics

Comments

@jsvd
Copy link
Member

jsvd commented Sep 11, 2015

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895
@jsvd jsvd mentioned this issue Sep 11, 2015
Closed
43 tasks
@talevy talevy assigned talevy and unassigned colinsurprenant Sep 16, 2015
talevy added a commit to talevy/logstash-input-syslog that referenced this issue Sep 17, 2015
@talevy
update to new shutdown semantics
57ba2c3 
Fixes logstash-plugins#20.
@talevy talevy mentioned this issue Sep 17, 2015
Closed
talevy added a commit to talevy/logstash-input-syslog that referenced this issue Sep 18, 2015
@talevy
update to new shutdown semantics
62c0c04 
Fixes logstash-plugins#20.
talevy added a commit to talevy/logstash-input-syslog that referenced this issue Sep 21, 2015
@talevy
update to new shutdown semantics
862945f 
Fixes logstash-plugins#20.
@talevy talevy closed this as completed in 1712508 Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talevy talevy

Labels
shutdown semantics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colinsurprenant @jsvd @talevy