fuse -> ROS 2 fuse_graphs : Port fuse_graphs #289
Conversation
methylDragon
force-pushed
the
rolling-graphs
branch
2 times, most recently
from
02d05fa to
cb7ea7d
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-graphs
branch
from
cb7ea7d to
720fb8c
Compare
fuse_graphs/CMakeLists.txt
Outdated
| cmake_minimum_required(VERSION 3.16) | ||
| project(fuse_graphs) | ||
|
|
||
| set(build_depends |
fuse_graphs/package.xml
Outdated
| <test_depend condition="$ROS_DISTRO >= melodic">benchmark</test_depend> | ||
| <test_depend>roslint</test_depend> | ||
| <test_depend>rostest</test_depend> | ||
| <buildtool_depend>ament_cmake</buildtool_depend> |
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
| #ifndef FUSE_GRAPHS_TEST_EXAMPLE_VARIABLE_H // NOLINT{build/header_guard} |
There was a problem hiding this comment.
Accidental copy of fuse_graphs/tests/example_variable.h?
There was a problem hiding this comment.
How did that happen 🤔
I hope it wasn't my script doing it :/
There was a problem hiding this comment.
Ah looks like it was being relied on by the benchmark. Adding the test directory as an include path should fix it
14:36:52 /tmp/ws/src/fuse/fuse_graphs/benchmark/benchmark_create_problem.cpp:39:10: fatal error: example_variable.h: No such file or directory
14:36:52 39 | #include "example_variable.h"
target_include_directories(benchmark_create_problem PRIVATE "test/")There was a problem hiding this comment.
Ah, you're right. I duplicated it because of that, but making it rely on test's version works too.
There was a problem hiding this comment.
|
@ros-pull-request-builder retest this please! |
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
rolling-graphs
branch
from
b1c8700 to
38006f3
Compare
|
@ros-pull-request-builder retest this please! |
sloretz
left a comment
sloretz
left a comment
There was a problem hiding this comment.
LGTM with RPr job where only linters for fuse_graphs are failing
|
Ah I see, https://build.ros2.org/job/Rpr__fuse__ubuntu_jammy_amd64/23/#showFailuresLink is for this PR (I see 38006f3 being checked out in the console text). Looks ready to merge to me! |
2 participants
See: #276
Description
This PR ports the entirety of fuse_graphs, including:
Other stuff like docs are in other PRs.
Some method signatures were altered in fuse_core to support the PR.
Notes
Pinging @svwilliams for visibility.