This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Conversation
This removes a rendering bug with tabpanes
|
Deploy PR Preview failed. |
alexrashed
approved these changes
Feb 13, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the upgrade! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently an issue with tabpanes such as the one underneath this heading - clicking multiple times on the "Homebrew" tab causes duplicate rendering of the box below it.
This PR updates the version of docsy which fixes this issue (actually fixed in this PR).
We should take the time to make sure this PR is acceptable, given the change log mentions some things we may want to investigate:
Tabbed panes, text display. By default, the content of a tab inside a tabbed pane is shown as code. As of version 0.4 of the shortcode, you can add the parameter code=false to your tabpane or tab shortcode in order to render tab content(s) as text (markdown or html). As of version 0.5 the name of this parameter was changed, we now use text=true in order to mark content as text.- we don't have any text tabsSimplified use of mermaid diagrams: when using a mermaid code block on your page, mermaid is now automatically enabled (needs hugo version >= 0.93.0). For existing sites build with hugo 0.93.0+, parameter mermaid.enable can be removed from site config.- we don't have any mermaid diagramsAnd maybe other things.
A quick eyeball of the front page shows some slightly adjusted styles (mostly padding related) but we should do a proper check of all pages.
This PR is currently in draft while @simonrw has a quick look.
Links to compare pages