Fix: Tabpane shows multiple tabs at the same time#1280
Merged
geriom merged 4 commits intogoogle:mainfrom Oct 21, 2022
Merged
Conversation
deining
force-pushed
the
issue-1271
branch
3 times, most recently
from
fcbc7d7 to
930bb9b
Compare
Remove trailing whitespace in a few .md files
… readfile shortcode (google#1289)
geriom
approved these changes
Oct 21, 2022
Collaborator
geriom
left a comment
geriom
left a comment
There was a problem hiding this comment.
Thank you! I tested it and it works perfectly. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses and closes #1271. It also closes #1289 . The
tabpaneshortcode was improved in the sense it now detects if the same language is assigned to different tabs. Once a duplicate language is detected, persistance of language is disabled for the affected tabpane, By doing so, we avoid multiple tab display for that tabpane. Additionally, a warning is printed, indicating to the user that duplicate language assignment was deteceted.Adiitonally this PR improves the whitespace handling of the shortcode, the produced html source code is correctly formatted now and can be read easily. Furthermore the PR includes a few minor fixes and improvements to the user guide.