Skip to content

Make LOCALSTACK_HOST static #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slang25 wants to merge 1 commit into from
Closed

Make LOCALSTACK_HOST static #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/Aspire.Hosting.LocalStack/Internal/LocalStackConnectionStringAvailableCallback.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System.Globalization;
using Aspire.Hosting.ApplicationModel;
using Aspire.Hosting.ApplicationModel;
using Aspire.Hosting.AWS.CloudFormation;
using Aspire.Hosting.LocalStack.Annotations;

Expand Down Expand Up @@ -38,9 +37,6 @@ internal static Func<ILocalStackResource, ConnectionStringAvailableEvent, Cancel

var localStackUrl = new Uri(connectionString);

var resourceBuilder = builder.CreateResourceBuilder(localStackResource);
resourceBuilder.WithEnvironment("LOCALSTACK_HOST", $"{localStackUrl.Host}:{localStackUrl.Port.ToString(CultureInfo.InvariantCulture)}");

var referencedResources = localStackResource.Annotations.OfType<LocalStackReferenceAnnotation>();
foreach (var resource in referencedResources.Select(annotation => annotation.Resource))
{
Expand Down
1 change: 1 addition & 0 deletions src/Aspire.Hosting.LocalStack/LocalStackResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ public static IDistributedApplicationBuilder UseLocalStack(this IDistributedAppl
.WithEnvironment("DEBUG", containerOptions.DebugLevel.ToString(CultureInfo.InvariantCulture))
.WithEnvironment("LS_LOG", containerOptions.LogLevel.ToEnvironmentValue())
.WithEnvironment("DOCKER_HOST", "unix:///var/run/docker.sock")
.WithEnvironment("LOCALSTACK_HOST", $"localhost:{Constants.DefaultContainerPort.ToString(CultureInfo.InvariantCulture)}")
.WithExternalHttpEndpoints()
.ExcludeFromManifest(); // LocalStack is for local development only

Expand Down
Loading