Make LOCALSTACK_HOST static #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slang25
force-pushed
the
fix-persistent-container
branch
from
6fbb270 to
56db39e
Compare
Contributor
|
I encountered the same issue. I think there’s a simpler and more portable fix for it. Currently, .WithHttpEndpoint(targetPort: Constants.DefaultContainerPort, name: LocalStackResource.PrimaryEndpointName)To resolve the issue, it should be enough to explicitly pass the .WithHttpEndpoint(targetPort: Constants.DefaultContainerPort, port: Constants.DefaultContainerPort, name: LocalStackResource.PrimaryEndpointName)Alternatively, the port could be provided as part of I ran some local tests, and this approach works correctly. Additionally, passing the port from the configuration helps prevent random port changes between runs, which is especially important when running the CLI. |
Contributor
|
I have prepared another PR for this issue: #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
My understanding is that the hostname localstack should be using should be consistent with it's external endpoint, so I think this change makes sense.