This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Rename field refrences to localgov #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looked good to me, I tested it with the Lambeth theme however it doesn't use these fields. I suppose that any subthemes relying on these machine names need to be updated too. |
field_addressfield => localgov_addressfield field_category => localgov_category field_email_address => localgov_email_address field_phone => localgov_phone field_website => localgov_website
andybroomfield
force-pushed
the
fix/152-renamed-fields
branch
from
4d4710c to
76f300b
Compare
finnlewis
approved these changes
Apr 6, 2021
Member
finnlewis
left a comment
finnlewis
left a comment
There was a problem hiding this comment.
Based on our testing on localgovdrupal/localgov#189, and conversations in Technical group meetings, I'm happy to approve this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #152.
To support
Updates the clean class in theme.
Only merge once the above have also merged
field_addressfield => localgov_addressfield
field_category => localgov_category
field_email_address => localgov_email_address
field_phone => localgov_phone
field_website => localgov_website