Rename the fields in localgov_services from field_ to localgov_ #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The tests will fail until localgov_core PR is also merged. |
…ding Renames the following: field_address_first_line => localgov_address_first_line field_address => localgov_address field_contact_us_online => localgov_contact_us_online field_destinations => localgov_destination field_hearing_difficulties_phone => localgov_hearing_difficulties_ph field_link_to_map => localgov_link_to_map field_opening_hours => localgov_opening_hours field_other_team_contacts => localgov_other_team_contacts field_popular_topics => localgov_popular_topics Uses the helper class in the updated version of localgov_core to do the renaming.
Search and replace accross localgov_services for the old fields provided by localgov_services_landing with field_ prefix to the localgov_ prefix
- Rename config field - Rename field references - Add updated hook in localgov_services_navigation
Renames: field_download_links => localgov_download_links field_hide_related_topics => localgov_hide_related_topics field_override_related_links => localgov_override_related_links field_related_links => localgov_related_links
field_service_status_on_list => localgov_service_status_on_list field_enable_service_updates => localgov_enable_service_updates field_service_status => localgov_service_status field_service_status_on_landing => localgov_service_status_on_landi
Apply bulk rename accross the field config and the whole module
Replaces: field_facebook => localgov_facebook field_twitter => localgov_twitter field_email_address => localgov_email_address field_phone => localgov_phone
This is to fix tests that look for specific elements.
andybroomfield
force-pushed
the
fix/75-rename-fields
branch
from
7da9b4b to
d57fbbe
Compare
…ponents Will require the page components update to be installed
finnlewis
approved these changes
Apr 6, 2021
Member
finnlewis
left a comment
finnlewis
left a comment
There was a problem hiding this comment.
Based on our testing on localgovdrupal/localgov#189, and conversations in Technical group meetings, I'm happy to approve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the renaming work related to localgovdrupal/localgov_core#37
To apply this PR, the above PR in localgov_core must also be merged.
This renames the configuration files and references for fields that start
with field_ to the correctly namespaced localgov_ equivilents.
This also does a search and replace accross the localgov_services module to
replace references to the renamed fields with the localgov_ versions.
Also adds an update hook that uses the field rename helper utility in the
localgov_core PR to update existing configuration.
Thanks to @stephen-cox for starting this, hope ok to take over to do the renaming.