Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade phpstan and deprecated code checking dependencies to 1.x #70

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Upgrade phpstan and deprecated code checking dependencies to 1.x #70

merged 4 commits into from
Apr 25, 2022

Conversation

stephen-cox
Copy link
Member

Closes #69

@finnlewis
Copy link
Member

So once this is merged: localgovdrupal/localgov_core#128 the tests should pass.

@stephen-cox
Copy link
Member Author

This can be merged once the following PRs are merged:

finnlewis
finnlewis approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, please release me!!

@stephen-cox stephen-cox merged commit bb62114 into 2.x Apr 25, 2022
@stephen-cox stephen-cox deleted the fix/2.x/69-upgrade-phpstan branch April 25, 2022 16:20
finnlewis added a commit that referenced this pull request Apr 26, 2022
@finnlewis @stephen-cox
Release 2.0.3 (#71)
6a760a7 
* Update node image to latest LTS, version 16
* Update github workflow configuration to match that on the localgov profile project.
* Update Lando to use the Drupal9 recipe and PHP 8.1.
* Set drupal_core_version to 9 and replace localgov_theme with localgov_base as the theme for coding standards review.
* Update allow-plugins config in composer.json to avoid having to confirm on install.
* Update test config trying to get it to run with multiple versions of PHP.
* Upgrade phpstan and deprecated code checking dependencies to 1.x (#70)
* Update allow-plugins config in composer.json to avoid having to confirm on install.

Co-authored-by: Finn <finn@agile.coop>
Co-authored-by: Finn <finn@opencode.uk>
Co-authored-by: Stephen Cox <stephen@agile.coop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finnlewis finnlewis finnlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade phpstan and related dependencies for PHP 8.1 support
2 participants
@stephen-cox @finnlewis