Fix 'Missing explicit access check on entity query.' #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnlewis
approved these changes
Apr 21, 2022
| @@ -70,7 +70,7 @@ function localgov_geo_update_8001() { | |||
| */ | |||
| function localgov_geo_update_8002(&$sandbox) { | |||
| if (!isset($sandbox['total'])) { | |||
| $sandbox['total'] = \Drupal::entityQuery('localgov_geo')->count()->execute(); | |||
| $sandbox['total'] = \Drupal::entityQuery('localgov_geo')->count()->accessCheck(FALSE)->execute(); | |||
There was a problem hiding this comment.
How come we're passing FALSE into accessCheck() here rather than TRUE?
There was a problem hiding this comment.
accessCheck(TRUE) will only return results that the current user has permissions to access, as this update should process all Geo entities I don't think the restriction is wanted here
| ->count() | ||
| ->accessCheck(TRUE) |
There was a problem hiding this comment.
I'm guessing the re-ordering is important here, but not sure why! Could you explain it to me?
There was a problem hiding this comment.
There was a bug in phpstan-drupal - this is now fixed, but this change doesn't change any functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51