-
Notifications
You must be signed in to change notification settings - Fork 6
Update Tablefield patch so that it works with Tablefield 2.x and 3.x #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Doesn't apply to 2.4 |
That's annoying. It applies fine to the 8.x-2.x branch which 2.4 is based off; although this release is now 2 years old. Not sure what to do about this then. The current patch doesn't work with the Tablefield 3 which is required for Drupal 11 support. Can we drop Tablefield 2 and require version 3 which supports Drupal 10 and 11, but only has a beta release? |
|
Patch does apply to Tablefield 2.5-RC2, so we could use this rather than drop support for version 2 entirely. |
|
https://git.drupalcode.org/project/tablefield/-/compare/8.x-2.x...3.0.x It'd be nice to drop 2.x, it's a straightforward update, but it would mean only supporting for 10.3. Is 10.2 out of support already, I've lost track of the best place to see this. |
|
So if we wait another week, we should have a 2.5 RC release of Table Field, and a 3.0.0 RC. Or we just target the beta now? |
|
I guess we can wait another week, but it sounds like targeting the 3.x beta is probably fine in reality. |
|
Discussing in Merge Tuesday, @ekes points out that the diff between 2.x and 3.x is not that large. So suggesting we target 3.0.0-beta2 to support Drupal 11 and then move ahead to RC and stable when released soon. |
* Update Tablefield patch so that it works with Tablefield 2.x and 3.x (#222) (#224) * Update Tablefield patch so that it works with Tablefield 2.x and 3.x #221 * Update composer.json to taget 3.0@beta --------- Co-authored-by: Stephen Cox <stephen-cox@users.noreply.github.com> * Remove version: VERSION from libraries --------- Co-authored-by: ekes <ekes@iskra.net> Co-authored-by: Finn Lewis <finn@opencode.uk> Co-authored-by: Stephen Cox <stephen-cox@users.noreply.github.com>
Fixes #221
What does this change?
Updates the patch from this issue https://www.drupal.org/project/tablefield/issues/3441319
How to test
Testing instructions on #213 apply to this PR as well.