-
Notifications
You must be signed in to change notification settings - Fork 2
adds publications to microsites #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@markconroy we've got a typo here I think, picked up by the coding standards checks: |
|
@markconroy mentions that the book outline is not showing up in the meta data sidebar. |
Blocks are now placed. |
|
Worth looking at: Might be worth upgrading to recent version of book. |
|
@rupertj have you successfully used localgov_publications in microsites? |
|
I've yet to try it, TBH. I don't think placing the blocks in this module is the right thing to do. Publications already tries to place the blocks using the block installer. If that's not happening on microsites, it'd be worth figuring out why. We could also place it the blocks in all the active themes for all the microsites. |
|
I can also confirm that child pages can be added to the parent publication and these pages aren't available to another domain on the same build |
What am I missing then? I still do not see the book outline when adding a publication page on a microsite. |
|
Might just need to add permission's for the book module? |
|
@finnlewis Wanna give this another spin? |
|
The issue stalled a bit, but the plan is to stop publications granting "administer book outlines". See localgovdrupal/localgov_publications#83. |
|
It also looks like there's some unrelated permissions in there. I don't think the ones that mention "group_term:localgov_topic" are anything to do with publications. |
|
Topic permissions have been removed now. |
|
Then for the blocks, I'm pretty sure that if you add localgov_microsites_base into this array here https://github.com/localgovdrupal/localgov_core/blob/2.x/src/Service/DefaultBlockInstaller.php#L63 you can get rid of the duplicated block config. That won't work for microsites that have their own theme and block configuration, but then the way this PR currently does it won't either. We could make that happen in localgov_core though. |
|
I'm also thinking that we could get rid of the whole concept of these submodules that integrate another module with microsites pretty easily by moving the microsites permissions hook to the module being supported and making the group relationship config optional, with a dependency on localgov_microsites_group, but that's probably out of scope for this PR. (Unless we want publications to be the guinea pig for that...) |
|
Thanks @rupertj you were right about adding Here's the related PR for LocalGov Core: localgovdrupal/localgov_core#324 |
|
Testing this again to see where we're at. Any recent updates @markconroy @rupertj @tonypaulbarker ? |
|
This does seem to work well now :) The publications (book) fields show in the sidebar for a trusted editor user on a microsite.
@rupertj @markconroy I do see "Breadcrumbs" listed in the "On this page" navigation. Is that a known issue?
|
|
It's new to me. Is there a hidden heading with text "Breadcrumbs" in the source? |
|
It's doing that because localgov_microsites_base has the breadcrumbs block hardcoded into the node-full template. |
|
On the breadcrumb issue, sounds like this is related so we can pick it up there and resolve localgovdrupal/localgov_microsites_base#338 |
|
Just chatting with @tonypaulbarker and we're happy to merge this and fix the breadcrumbs issue on localgovdrupal/localgov_microsites_base#338 Thanks @markconroy @rupertj and @AWearring :) |




Closes #555
Not completed yet. This add the config for publications, but does not have the "Book Outline" field in the node create/edit sidebar.
What does this change?
Configures publications module for microsites.
How to test
How can we measure success?
People no longer ask us to add Publications to Microsites.
Thanks to Big Blue Door for sponsoring my time to work on this.