Check for body field before acting on it #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekes
reviewed
May 6, 2025
| $this->drupalGet($overview->toUrl()->toString()); | ||
| $this->assertSession()->responseNotContains('Lede to show'); | ||
| // @todo remove this. | ||
| drupal_flush_all_caches(); |
Member
There was a problem hiding this comment.
Test adds checks lede shows in the first place and confirms it works when the field is removed.
However it needs the cache clear, so I'll create a follow-up issue about the caching of the block (guessing it wants cache metadata, rather than just cache tags).
Member
There was a problem hiding this comment.
ekes
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
What does this change?
Simple check to see if the body field exists before we act on it.
How to test
Delete body field from guide page content type, the pageHeader block will cause a WSOD. Checkout this branch, clear your cache, and then refresh your page and the pageHeader block should be working again.