Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-setup-in-describe to not flag describe.skip() #256

Merged
merged 1 commit into from
May 30, 2020
Merged

Fix no-setup-in-describe to not flag describe.skip() #256

merged 1 commit into from
May 30, 2020

Conversation

lo1tuma
Copy link
Owner

@lo1tuma lo1tuma commented May 29, 2020

Fixes #249.

@lo1tuma lo1tuma added the bug label May 29, 2020
screendriver
screendriver approved these changes May 30, 2020
View reviewed changes
Copy link
Collaborator

@screendriver screendriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@lo1tuma lo1tuma merged commit 344a6f6 into master May 30, 2020
@lo1tuma lo1tuma deleted the gh-249 branch May 30, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@screendriver screendriver screendriver approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-setup-in-describe triggers on describe.skip
2 participants
@lo1tuma @screendriver