Merge pull request #256 from lo1tuma/gh-249

Fix no-setup-in-describe to not flag describe.skip()
lo1tuma · May 30, 2020 · 344a6f6 · 344a6f6
2 parents 35dfc76 + d1ed7d4
commit 344a6f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/rules/no-setup-in-describe.js b/lib/rules/no-setup-in-describe.js
@@ -83,7 +83,7 @@ module.exports = {
             },
 
             MemberExpression(node) {
-                if (isNestedInDescribeBlock()) {
+                if (!isDescribe(node.parent) && isNestedInDescribeBlock()) {
                     reportMemberExpression(node);
                 }
             },

diff --git a/test/rules/no-setup-in-describe.js b/test/rules/no-setup-in-describe.js
@@ -19,6 +19,9 @@ ruleTester.run('no-setup-in-describe', rule, {
         'it("", function () { a[b]; })',
         'it("", function () { a["b"]; })',
         'describe("", function () { it(); })',
+        'describe.skip("", function () { it(); })',
+        'describe.only("", function () { it(); })',
+        'describe["only"]("", function () { it(); })',
         'describe("", function () { this.slow(1); it(); })',
         'describe("", function () { this.timeout(1); it(); })',
         'describe("", function () { this.retries(1); it(); })',