feat/business-account by islandbitcoin · Pull Request #224 · lnflash/flash

islandbitcoin · 2025-10-17T12:43:27Z

Mutation:

Ingest the information given from the user when filling out the business upgrade form. (regardless of Pro or Merchant)
create a new support issue in ERPNext using the erpnext class on the backend.
add user info to the issue in description field, formatted for future parsing
Condition: if upgrade to level TWO, this mutation should also trigger autoupgrade to level TWO without admin input. if upgrade to level THREE, manual approval required, so this mutation does nothing else.

Query:

Client needs to know if a request is pending, so a query is needed to look for existing open support issues connected to this user.
query should ingest username, and return a boolean.

islandbitcoin · 2025-10-17T13:35:23Z

@brh28 this still needs to be wired up to the ErpNext support issue structure (WIP)

brh28

Have you tested this code against ErpNext? I'm wondering if the read/writes using the subject field is working correctly

brh28 · 2025-10-20T16:53:03Z

src/app/accounts/business-account-upgrade-request.ts

+  if (account instanceof Error) return account
+
+  // Validate requested level
+  const checkedLevel = checkedToAccountLevel(level)


lines 43-54 could be combined into a single function. something like:

const checkedLevel = validate(level, [ isValid, isGreaterThan(account.level)] )

brh28 · 2025-10-20T16:55:20Z

src/app/accounts/business-account-upgrade-request.ts

+
+  if (issueResult instanceof Error) return issueResult
+
+  // If level is 2 (Pro), auto-upgrade immediately


For level 2, why create an issue in ErpNext if we're already upgrading them?

so we can have the update records in ErpNext, with timestamps, and saving their bank account information if they enter it, since it is optional for level 2.

brh28 · 2025-10-20T17:08:21Z

src/services/frappe/ErpNext.ts

+  /**
+   * Create a support Issue in ERPNext for account upgrade requests
+   */
+  async createSupportIssue(data: {


I'd recommend changing the interface so that the caller doesn't need to know the implementation details. For example:

createAccountUpgradeRequest(username, details) getAccountUpgradeRequest(username)

This way, all the logic for handling upgrade requests is contained in this file, rather than spread through the code.

@Nodirbek75 this is where the account upgrade request is made

islandbitcoin · 2025-12-03T12:39:39Z

doctype: Account Upgrade Request
fields:
{
current_level: "ZERO" | "ONE" | "TWO" | "THREE"
requested_level: "ZERO" | "ONE" | "TWO" | "THREE"
username: string
full_name: string
phone_number: string
email?: string
business_name?: string
business_address?: string
terminal_requested?: boolean
bank_name?: string
bank_branch?: string
account_type?: string
currency?: string
account_number?: number
id_document?: string
status: "Pending" | "Approved" | "Rejected"
}

brh28 · 2025-12-16T19:36:06Z

dev/config/base-config.yaml

    # get from ErpNext user -> settings -> API Access
-    apiKey: "" 
-    apiSecret: ""
+    apiKey: "293bac5aa957da3"


brh28 · 2025-12-16T19:53:42Z

src/graphql/public/schema.graphql

  helmRevision: Int
 }

+input BusinessAccountUpgradeRequestInput {


should be updated to include all required fields

brh28 · 2025-12-16T20:50:40Z

src/app/accounts/business-account-upgrade-request.ts

+  if (requestResult instanceof Error) return requestResult
+
+  // Level 2 (Pro) auto-upgrades immediately
+  if (checkedLevel === 2) {


perhaps use AccountLevel enum: e.g AccountLevel.Pro

brh28 · 2025-12-16T20:51:03Z

src/services/frappe/ErpNext.ts

-const erpUsd = (usd: USDAmount): number => Number(usd.asCents(2)) // Number(usd.asDollars(2))
+const erpUsd = (usd: USDAmount): number => Number(usd.asCents(2))
+
+type ErpLevelString = "ZERO" | "ONE" | "TWO" | "THREE"


Should be AccountLevels?

updated. I had to map the numbers to Erp strings

islandbitcoin · 2025-12-17T20:37:44Z

works™

* untested: create AccountUpgradeRequest class * restore caps changes

islandbitcoin mentioned this pull request Oct 17, 2025

[feat]: Add account level upgrade mutation #217

Closed

islandbitcoin assigned islandbitcoin and brh28 and unassigned brh28 Oct 17, 2025

islandbitcoin added the enhancement New feature or request label Oct 17, 2025

brh28 and others added 4 commits October 17, 2025 15:11

Draft journal entry prior to payment & handle errors

8b08f88

Clean up draft records

73f26b3

refactored to account for ERPNext integration

ceb3338

fix linting errors

f94aa26

islandbitcoin force-pushed the feat/business-account branch from 0f9f6cb to f94aa26 Compare October 17, 2025 19:16

islandbitcoin requested a review from brh28 October 17, 2025 19:17

brh28 reviewed Oct 20, 2025

View reviewed changes

islandbitcoin marked this pull request as draft October 30, 2025 17:21

islandbitcoin linked an issue Oct 31, 2025 that may be closed by this pull request

Merchant Upgrade flow Step 3: Update users to Level 3 Account - Merchant #164

Closed

islandbitcoin added 4 commits December 4, 2025 08:12

update to use doctype: Account Upgrade Request

c9efc1c

Merge remote-tracking branch 'origin' into feat/business-account

a5f0511

MVP version changes

a231176

update ErpNext

4e1dd99

brh28 reviewed Dec 16, 2025

View reviewed changes

islandbitcoin marked this pull request as ready for review December 17, 2025 20:38

islandbitcoin requested a review from brh28 December 17, 2025 20:38

updates based on PR feedback

96ee680

islandbitcoin force-pushed the feat/business-account branch from 2e2420c to 96ee680 Compare December 17, 2025 21:19

islandbitcoin added 2 commits December 17, 2025 16:34

update to AccountLevel enum based on PR feedback

448d4b0

update leveltoerpstring

7b80f31

Feat/business account (#244)

a7c847d

* untested: create AccountUpgradeRequest class * restore caps changes

islandbitcoin changed the title ~~new graphql mutation and query for upgrading to pro/merchant account~~ feat/business-account Dec 29, 2025

review changes

51f1112

brh28 approved these changes Dec 30, 2025

View reviewed changes

islandbitcoin merged commit 3135e1e into main Dec 30, 2025


		if (issueResult instanceof Error) return issueResult

		// If level is 2 (Pro), auto-upgrade immediately

Conversation

islandbitcoin commented Oct 17, 2025

Mutation:

Query:

Uh oh!

islandbitcoin commented Oct 17, 2025

Uh oh!

brh28 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

islandbitcoin commented Dec 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

islandbitcoin commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants