[feat]: Add account level upgrade mutation#217
Conversation
…er record in mongodb
There was a problem hiding this comment.
Pull Request Overview
Implements a self-service account level upgrade mutation that allows authenticated users to upgrade their KYC level after admin validation. This creates a controlled upgrade flow where admins validate user data first, then users can perform the upgrade themselves.
- Added
validatedboolean field to User schema for single-use validation control - Created
selfUpgradeAccountLevelbusiness logic with upgrade-only restrictions - Implemented public GraphQL mutation
accountUpdateLevelfor user-initiated upgrades
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/services/mongoose/schema.ts | Added validated boolean field with index to User schema |
| src/services/mongoose/users.ts | Updated user translation and repository to handle validated field |
| src/app/accounts/self-upgrade-account-level.ts | New business logic for self-service account upgrades with validation checks |
| src/app/accounts/index.ts | Exported new self-upgrade function |
| src/graphql/public/types/payload/account-update-level.ts | New payload type for account level update responses |
| src/graphql/public/root/mutation/account-update-level.ts | New GraphQL mutation for user-initiated account level upgrades |
| src/graphql/public/mutations.ts | Registered new mutation in public API |
| src/graphql/public/schema.graphql | Added GraphQL schema definitions for new mutation |
| dev/apollo-federation/supergraph.graphql | Updated federation schema with new types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
From what I gather this flow has 3 parts:
but I'm confused why step 3 is necessary. It seems this flow would be simpler if a user could trigger a request to upgrade, then an admin approves the request, which updates the account |
that would be a better flow. |
…s/mongoose/schema.ts:485-489) - Replaced validated boolean with requestedLevel field - Stores the user's pending upgrade request (null = no request) 2. Type Definitions - Updated User type in src/domain/users/index.types.d.ts:69 - Updated UserRecord in src/services/mongoose/schema.types.d.ts:153 - Updated repository in src/services/mongoose/users.ts:16,28,71,82 3. Business Logic - New: src/app/accounts/request-account-level-upgrade.ts - Users request upgrades - Enhanced: src/app/accounts/update-account-level.ts:20-29 - Admin approval clears request - Deleted: src/app/accounts/self-upgrade-account-level.ts - Removed confusing flow 4. GraphQL API - User mutation: accountLevelUpgradeRequest - Users submit upgrade requests(src/graphql/public/root/mutation/account-level-upgrade-request.ts) - Admin mutation: Existing accountUpdateLevel now auto-clears requests - Removed: Public accountUpdateLevel mutation (users can't self-upgrade) 5. Schema Updates - Updated src/graphql/public/schema.graphql:102-104, 741 - Removed old payload types How It Works 1. User requests: accountLevelUpgradeRequest(level: 2) → sets user.requestedLevel = 2 2. Admin reviews: Queries existing admin tools, sees requestedLevel: 2 on user 3. Admin approves: Calls accountUpdateLevel → upgrades account + clears requestedLevel
islandbitcoin
changed the title
|
based on today's dev standup, this should refactored to create a new graphql mutation and a query. Mutation:
Query:
|
|
I've created a new PR for this change in direction: #224 Closing this PR. |
Implements a new GraphQL mutation that allows authenticated users to upgrade their account level (KYC level) if they have been validated by an admin.
Key features:
Changes:
This creates a controlled upgrade flow where admins or another function can validate user data, then the front-end can auto-upgrade once per validation.