OnnxToTorch bicubic interpolation #3802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesilv
force-pushed
the
cubic
branch
5 times, most recently
from
5635202 to
71487e6
Compare
aldesilv
force-pushed
the
cubic
branch
5 times, most recently
from
f4c442b to
f718e52
Compare
zjgarvey
reviewed
Nov 8, 2024
aldesilv
force-pushed
the
cubic
branch
2 times, most recently
from
1ed2b47 to
a4d7d79
Compare
zjgarvey
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Before making changes, check out the suggestions for fixing the numerics in aldesilv#3.
Besides the suggestions in that PR, and the comments in this review, I'd generally like more comments in this code. Where does this implementation come from? What assumptions did we make?
To anyone who doesn't have context on cubic interpolation, this code would be completely inscrutable.
aldesilv
force-pushed
the
cubic
branch
2 times, most recently
from
b5519b8 to
2dfcc1c
Compare
zjgarvey
reviewed
Nov 12, 2024
rahuls-cerebras
added a commit
that referenced
this pull request
Jan 3, 2025
This reverts commit 889a836.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(nod-ai/SHARK-TestSuite#391)
Repro (using SHARK TestSuite):
python run.py --torchtolinalg -m cl-onnx-iree -t cubic_test