Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onnx] Add IDF and TFIDF modes to TFIDF Vectorizer #3726

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

samutamm
Copy link
Contributor

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to address and I think this will be good to go! Thanks.

@zjgarvey zjgarvey self-requested a review September 26, 2024 16:54
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good to me.

@zjgarvey zjgarvey merged commit a2bfe47 into llvm:main Oct 2, 2024
3 checks passed
@samutamm samutamm deleted the 833-tfidfvectorizer-modes branch October 10, 2024 12:07
samutamm added a commit to nod-ai/SHARK-TestSuite that referenced this pull request Oct 31, 2024
Add few end-to-end test cases for IDF and TFIDF modes of [TFIDF
Vectorizer](https://github.com/onnx/onnx/blob/main/docs/Operators.md#TfIdfVectorizer).

Corresponding changes in torch-mlir:
llvm/torch-mlir#3726

---------

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants