[OpenMP] Fix or disable NVPTX tests failing currently #77844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
requested review from
doru1004,
jdoerfert,
jplehr,
Meinersbur,
ronlieb and
shiltian
Meinersbur
approved these changes
Jan 12, 2024
|
|
||
| // TODO: This requires malloc support for the threads states. | ||
| // FIXME: Flaxy on all GPU targets. |
| @@ -3,7 +3,7 @@ | |||
| // complaint anymore, especially when the user isn't targeting CUDA. | |||
|
|
|||
| // RUN: %libomptarget-compile-generic | |||
| // RUN: env CUDA_VISIBLE_DEVICES= \ | |||
| // RUN: env CUDA_VISIBLE_DEVICES="" ROCR_VISIBLE_DEVICES="" \ | |||
There was a problem hiding this comment.
Added ROCR_VISIBLE_DEVICES is not for NVPTX.
Summary: This patch is an attempt to get a clean run of `check-openmp` running on an NVPTX machine. I simply took the lists of tests that failed on my `sm_89` machine and disabled them or fixed them. A lot of these tests are disabled on AMDGPU already, so it makes sense that NVPTX fails. The others are simply problems with NVPTX optimized debugging which will need to be fixed. I opened an issue on one of them.
jhuber6
force-pushed
the
FixNVPTXTests
branch
from
83f9583 to
555335a
Compare
It's a known problem, that issue is definitely related. not sure what the best way to handle it here is. |
|
@Meinersbur what's the link for your bot again? |
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Summary: This patch is an attempt to get a clean run of `check-openmp` running on an NVPTX machine. I simply took the lists of tests that failed on my `sm_89` machine and disabled them or fixed them. A lot of these tests are disabled on AMDGPU already, so it makes sense that NVPTX fails. The others are simply problems with NVPTX optimized debugging which will need to be fixed. I opened an issue on one of them.
shiltian
reviewed
Dec 3, 2024
| // XFAIL: amdgcn-amd-amdhsa | ||
| // XFAIL: nvptx64-nvidia-cuda |
There was a problem hiding this comment.
probably nvptx fixed the issue in some version. this can constantly pass on my local machine with CUDA 12.6.
********************
Unexpectedly Passed Tests (2):
libomptarget :: nvptx64-nvidia-cuda :: unified_shared_memory/api.c
libomptarget :: nvptx64-nvidia-cuda :: unified_shared_memory/close_enter_exit.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch is an attempt to get a clean run of
check-openmprunning onan NVPTX machine. I simply took the lists of tests that failed on my
sm_89machine and disabled them or fixed them. A lot of these testsare disabled on AMDGPU already, so it makes sense that NVPTX fails. The
others are simply problems with NVPTX optimized debugging which will
need to be fixed. I opened an issue on one of them.