Skip to content

Commit 555335a

Browse files
committed
[OpenMP] Fix or disable NVPTX tests failing currently
Summary: This patch is an attempt to get a clean run of `check-openmp` running on an NVPTX machine. I simply took the lists of tests that failed on my `sm_89` machine and disabled them or fixed them. A lot of these tests are disabled on AMDGPU already, so it makes sense that NVPTX fails. The others are simply problems with NVPTX optimized debugging which will need to be fixed. I opened an issue on one of them.
1 parent 8fb8ad6 commit 555335a

10 files changed

+29
-2
lines changed

openmp/libomptarget/test/libc/assert.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
// REQUIRES: libc
55

6+
// NVPTX without LTO uses the implementation in OpenMP currently.
7+
// UNSUPPORTED: nvptx64-nvidia-cuda
68
// UNSUPPORTED: powerpc64-ibm-linux-gnu
79
// UNSUPPORTED: powerpc64-ibm-linux-gnu-LTO
810
// UNSUPPORTED: aarch64-unknown-linux-gnu

openmp/libomptarget/test/mapping/target_derefence_array_pointrs.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22
// RUN: %libomptarget-run-generic 2>&1 \
33
// RUN: | %fcheck-generic
44

5+
// FIXME: This is currently broken on all GPU targets
56
// UNSUPPORTED: amdgcn-amd-amdhsa
7+
// UNSUPPORTED: nvptx64-nvidia-cuda
8+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
69

710
#include <stdio.h>
811
#include <stdlib.h>

openmp/libomptarget/test/mapping/target_uses_allocator.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// RUN: %libomptarget-compile-run-and-check-generic
22

3+
// FIXME: https://github.com/llvm/llvm-project/issues/77841
34
// UNSUPPORTED: amdgcn-amd-amdhsa
5+
// UNSUPPORTED: nvptx64-nvidia-cuda
6+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
47

58
#include <omp.h>
69
#include <stdio.h>

openmp/libomptarget/test/mapping/target_wrong_use_device_addr.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// RUN: env LIBOMPTARGET_INFO=64 %libomptarget-run-fail-generic 2>&1 \
33
// RUN: | %fcheck-generic
44

5+
// FIXME: Fails due to optimized debugging in 'ptxas'
6+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
7+
58
#include <stdio.h>
69

710
int main() {

openmp/libomptarget/test/offloading/bug64959.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
// RUN: %libomptarget-compilexx-run-and-check-generic
2-
// RUN: %libomptarget-compileoptxx-run-and-check-generic
1+
// RUN: %libomptarget-compile-run-and-check-generic
2+
// RUN: %libomptarget-compileopt-run-and-check-generic
33

44
// TODO: This requires malloc support for the threads states.
5+
// FIXME: Flaky on all GPU targets.
56
// UNSUPPORTED: amdgcn-amd-amdhsa
7+
// UNSUPPORTED: nvptx64-nvidia-cuda
8+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
69

710
#include <omp.h>
811
#include <stdio.h>

openmp/libomptarget/test/offloading/info.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
// RUN: env LIBOMPTARGET_INFO=63 %libomptarget-run-amdgcn-amd-amdhsa 2>&1 | \
66
// RUN: %fcheck-amdgcn-amd-amdhsa -allow-empty -check-prefixes=INFO,AMDGPU
77

8+
// FIXME: Fails due to optimized debugging in 'ptxas'.
9+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
10+
811
#include <omp.h>
912
#include <stdio.h>
1013

openmp/libomptarget/test/offloading/std_complex_arithmetic.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
// FIXME: This fails to link due to missing math symbols. We should provide the
77
// needed math functions in the GPU `libm` and require the GPU C library.
88
// UNSUPPORTED: amdgcn-amd-amdhsa
9+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
910

1011
#include <cassert>
1112
#include <complex>

openmp/libomptarget/test/unified_shared_memory/close_enter_exit.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
// UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
55

66
// Fails on amdgpu with error: GPU Memory Error
7+
// Fails on nvptx with error: an illegal memory access was encountered
78
// XFAIL: amdgcn-amd-amdhsa
9+
// XFAIL: nvptx64-nvidia-cuda
10+
// XFAIL: nvptx64-nvidia-cuda-LTO
811

912
#include <omp.h>
1013
#include <stdio.h>

openmp/libomptarget/test/unified_shared_memory/close_modifier.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
// UNSUPPORTED: clang-6, clang-7, clang-8, clang-9
55

66
// amdgpu runtime crash
7+
// Fails on nvptx with error: an illegal memory access was encountered
78
// UNSUPPORTED: amdgcn-amd-amdhsa
9+
// UNSUPPORTED: nvptx64-nvidia-cuda
10+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
811

912
#include <omp.h>
1013
#include <stdio.h>

openmp/libomptarget/test/unified_shared_memory/shared_update.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
// REQUIRES: unified_shared_memory
44

55
// amdgpu runtime crash
6+
// Fails on nvptx with error: an illegal memory access was encountered
67
// UNSUPPORTED: amdgcn-amd-amdhsa
8+
// UNSUPPORTED: nvptx64-nvidia-cuda
9+
// UNSUPPORTED: nvptx64-nvidia-cuda-LTO
710

811
#include <omp.h>
912
#include <stdio.h>

0 commit comments

Comments
 (0)