[llvm-mca][AArch64] Refactor Neoverse tests to split out common inputs (NFC) #170324
+3,811
−10,540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (NFC) For many of these tests the inputs are very similiar with slight divergences, we should work to make common sources where we can to avoid subtle differences. Changes: - For basic tests there's a relatively large diff between V1 and all other cores because of 24f0901 (llvm#128892) which makes it more complete. I've been thru the entire diff and 99% of the time V1 makes more sense, except for a couple of small changes (might post a separate patch for). Therefore I decided it's best to take V1-basic-instructions.s as the common source. - Split out FEAT_RCPC_IMMO tests from basic since N1 doesnt have this feature. - Split out FEAT_MTE tests. V2/V3 also have this feature but were missing tests, so I've added them. The NEON and SVE tests are also quite substantial and could be made common, but there's also subtle differences that take time to go thru.
Asher8118
reviewed
Dec 2, 2025
Contributor
Asher8118
left a comment
Asher8118
left a comment
There was a problem hiding this comment.
I think the change makes sense and I agree that a common source for testing is a good direction.
I've been thru the entire diff and 99% of the time V1 makes more sense, except for a couple of small changes (might post a separate patch for).
One question, in the cases where we do have even slight divergence, what is the plan? Add those instructions specifically as a separate test to avoid duplication?
The NEON and SVE tests are also quite substantial and could be made common, but there's also subtle differences that take time to go thru
I think as long as exceptions are handled as well, that would still be an improvement to the amount of duplication we currently have in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many of these tests the inputs are very similiar with slight divergences, ideally we'd have common sources where we can to avoid subtle differences.
Changes:
The NEON and SVE tests are also quite substantial and could be made common, but there's also subtle differences that take time to go thru.