build_llvm_release.bat: Put the 32-bit sanitizers back #166437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to bcb3d2f. Even though 32-bit win/asan is not well supported, we shouldn't drop it without some discussion at least. Also, we probably shouldn't drop the other sanitizers that are gated by COMPILER_RT_BUILD_SANITIZERS. The tests no longer pass after switching to the runtimes build however (I believe that build mode runs more of the tests?), so disable them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to bcb3d2f.
Even though 32-bit win/asan is not well supported, we shouldn't drop it without some discussion at least. Also, we probably shouldn't drop the other sanitizers that are gated by COMPILER_RT_BUILD_SANITIZERS.
The tests no longer pass after switching to the runtimes build however (I believe that build mode runs more of the tests?), so disable them.