Skip to content

Commit 6f91f58

Browse files
authored
build_llvm_release.bat: Put the 32-bit sanitizers back (#166437)
Follow-up to bcb3d2f. Even though 32-bit win/asan is not well supported, we shouldn't drop it without some discussion at least. Also, we probably shouldn't drop the other sanitizers that are gated by COMPILER_RT_BUILD_SANITIZERS. The tests no longer pass after switching to the runtimes build however (I believe that build mode runs more of the tests?), so disable them.
1 parent 718818a commit 6f91f58

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

llvm/utils/release/build_llvm_release.bat

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ set "stage0_bin_dir=%build_dir%/build32_stage0/bin"
220220
set cmake_flags=^
221221
%common_cmake_flags% ^
222222
-DLLVM_ENABLE_RPMALLOC=OFF ^
223-
-DCOMPILER_RT_BUILD_SANITIZERS=OFF ^
224223
-DPython3_ROOT_DIR=%PYTHONHOME% ^
225224
-DLIBXML2_INCLUDE_DIR=%libxmldir%/include/libxml2 ^
226225
-DLIBXML2_LIBRARIES=%libxmldir%/lib/libxml2s.lib
@@ -230,7 +229,7 @@ ninja || ninja || ninja || exit /b 1
230229
REM ninja check-llvm || ninja check-llvm || ninja check-llvm || exit /b 1
231230
REM ninja check-clang || ninja check-clang || ninja check-clang || exit /b 1
232231
ninja check-lld || ninja check-lld || ninja check-lld || exit /b 1
233-
ninja check-runtimes || ninja check-runtimes || ninja check-runtimes || exit /b 1
232+
REM ninja check-runtimes || ninja check-runtimes || ninja check-runtimes || exit /b 1
234233
REM ninja check-clang-tools || ninja check-clang-tools || ninja check-clang-tools || exit /b 1
235234
cd..
236235

@@ -239,7 +238,6 @@ REM with forward slash.
239238
set all_cmake_flags=^
240239
%cmake_flags% ^
241240
-DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;lld;lldb;" ^
242-
-DCOMPILER_RT_BUILD_SANITIZERS=OFF ^
243241
%common_lldb_flags% ^
244242
-DPYTHON_HOME=%PYTHONHOME% ^
245243
-DCMAKE_C_COMPILER=%stage0_bin_dir%/clang-cl.exe ^
@@ -256,7 +254,7 @@ ninja || ninja || ninja || exit /b 1
256254
REM ninja check-llvm || ninja check-llvm || ninja check-llvm || exit /b 1
257255
REM ninja check-clang || ninja check-clang || ninja check-clang || exit /b 1
258256
ninja check-lld || ninja check-lld || ninja check-lld || exit /b 1
259-
ninja check-runtimes || ninja check-runtimes || ninja check-runtimes || exit /b 1
257+
REM ninja check-runtimes || ninja check-runtimes || ninja check-runtimes || exit /b 1
260258
REM ninja check-clang-tools || ninja check-clang-tools || ninja check-clang-tools || exit /b 1
261259
ninja package || exit /b 1
262260
cd ..

0 commit comments

Comments
 (0)