[SelectionDAG][X86] Handle llvm.type.test in DAGBuilder
#142939
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-x86 Author: Abhishek Kaushik (abhishek-kaushik22) ChangesCloses #142937 Full diff: https://github.com/llvm/llvm-project/pull/142939.diff 2 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index 2460c864b0815..6bb8368252537 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -7384,6 +7384,22 @@ void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
setValue(&I, getValue(I.getOperand(0)));
return;
+ case Intrinsic::type_test:
+ case Intrinsic::public_type_test: {
+ bool AllUsersAreAssume = llvm::all_of(I.users(), [](const User *U) {
+ if (const auto *call = dyn_cast<CallInst>(U)) {
+ return call->getIntrinsicID() == Intrinsic::assume;
+ }
+ return false;
+ });
+
+ if (AllUsersAreAssume)
+ setValue(&I, DAG.getUNDEF(MVT::i1));
+ else
+ setValue(&I, DAG.getConstant(1, sdl, MVT::i1));
+ return;
+ }
+
case Intrinsic::assume:
case Intrinsic::experimental_noalias_scope_decl:
case Intrinsic::var_annotation:
diff --git a/llvm/test/CodeGen/X86/pr142937.ll b/llvm/test/CodeGen/X86/pr142937.ll
new file mode 100644
index 0000000000000..269433d86ba7d
--- /dev/null
+++ b/llvm/test/CodeGen/X86/pr142937.ll
@@ -0,0 +1,62 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc < %s -mtriple=i686-- -opt-bisect-limit=0 | FileCheck %s --check-prefix=X86
+; RUN: llc < %s -mtriple=x86_64-- -opt-bisect-limit=0 | FileCheck %s --check-prefix=X64
+
+define void @public_type_test() {
+; X86-LABEL: public_type_test:
+; X86: # %bb.0: # %bb
+; X86-NEXT: # %bb.1: # %bb1
+; X86-NEXT: retl
+;
+; X64-LABEL: public_type_test:
+; X64: # %bb.0: # %bb
+; X64-NEXT: # %bb.1: # %bb1
+; X64-NEXT: retq
+bb:
+ %call = call i1 @llvm.public.type.test(ptr null, metadata !"typeinfo")
+ br label %bb1
+
+bb1:
+ call void @llvm.assume(i1 %call)
+ ret void
+}
+
+define void @type_test() {
+; X86-LABEL: type_test:
+; X86: # %bb.0: # %bb
+; X86-NEXT: movb $1, %al
+; X86-NEXT: testb $1, %al
+; X86-NEXT: jne .LBB1_2
+; X86-NEXT: # %bb.1: # %bb1
+; X86-NEXT: ud1l 2(%eax), %eax
+; X86-NEXT: .LBB1_2: # %bb2
+; X86-NEXT: retl
+;
+; X64-LABEL: type_test:
+; X64: # %bb.0: # %bb
+; X64-NEXT: movb $1, %al
+; X64-NEXT: testb $1, %al
+; X64-NEXT: jne .LBB1_2
+; X64-NEXT: # %bb.1: # %bb1
+; X64-NEXT: ud1l 2(%eax), %eax
+; X64-NEXT: .LBB1_2: # %bb2
+; X64-NEXT: retq
+bb:
+ %call = tail call i1 @llvm.type.test(ptr null, metadata !"typeinfo")
+ br i1 %call, label %bb2, label %bb1
+
+bb1:
+ tail call void @llvm.ubsantrap(i8 2)
+ unreachable
+
+bb2:
+ ret void
+}
+
+declare i1 @llvm.public.type.test(ptr, metadata)
+
+declare void @llvm.assume(i1 noundef)
+
+declare i1 @llvm.type.test(ptr, metadata)
+
+declare void @llvm.ubsantrap(i8 immarg)
|
|
@llvm/pr-subscribers-llvm-selectiondag Author: Abhishek Kaushik (abhishek-kaushik22) ChangesCloses #142937 Full diff: https://github.com/llvm/llvm-project/pull/142939.diff 2 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index 2460c864b0815..6bb8368252537 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -7384,6 +7384,22 @@ void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
setValue(&I, getValue(I.getOperand(0)));
return;
+ case Intrinsic::type_test:
+ case Intrinsic::public_type_test: {
+ bool AllUsersAreAssume = llvm::all_of(I.users(), [](const User *U) {
+ if (const auto *call = dyn_cast<CallInst>(U)) {
+ return call->getIntrinsicID() == Intrinsic::assume;
+ }
+ return false;
+ });
+
+ if (AllUsersAreAssume)
+ setValue(&I, DAG.getUNDEF(MVT::i1));
+ else
+ setValue(&I, DAG.getConstant(1, sdl, MVT::i1));
+ return;
+ }
+
case Intrinsic::assume:
case Intrinsic::experimental_noalias_scope_decl:
case Intrinsic::var_annotation:
diff --git a/llvm/test/CodeGen/X86/pr142937.ll b/llvm/test/CodeGen/X86/pr142937.ll
new file mode 100644
index 0000000000000..269433d86ba7d
--- /dev/null
+++ b/llvm/test/CodeGen/X86/pr142937.ll
@@ -0,0 +1,62 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc < %s -mtriple=i686-- -opt-bisect-limit=0 | FileCheck %s --check-prefix=X86
+; RUN: llc < %s -mtriple=x86_64-- -opt-bisect-limit=0 | FileCheck %s --check-prefix=X64
+
+define void @public_type_test() {
+; X86-LABEL: public_type_test:
+; X86: # %bb.0: # %bb
+; X86-NEXT: # %bb.1: # %bb1
+; X86-NEXT: retl
+;
+; X64-LABEL: public_type_test:
+; X64: # %bb.0: # %bb
+; X64-NEXT: # %bb.1: # %bb1
+; X64-NEXT: retq
+bb:
+ %call = call i1 @llvm.public.type.test(ptr null, metadata !"typeinfo")
+ br label %bb1
+
+bb1:
+ call void @llvm.assume(i1 %call)
+ ret void
+}
+
+define void @type_test() {
+; X86-LABEL: type_test:
+; X86: # %bb.0: # %bb
+; X86-NEXT: movb $1, %al
+; X86-NEXT: testb $1, %al
+; X86-NEXT: jne .LBB1_2
+; X86-NEXT: # %bb.1: # %bb1
+; X86-NEXT: ud1l 2(%eax), %eax
+; X86-NEXT: .LBB1_2: # %bb2
+; X86-NEXT: retl
+;
+; X64-LABEL: type_test:
+; X64: # %bb.0: # %bb
+; X64-NEXT: movb $1, %al
+; X64-NEXT: testb $1, %al
+; X64-NEXT: jne .LBB1_2
+; X64-NEXT: # %bb.1: # %bb1
+; X64-NEXT: ud1l 2(%eax), %eax
+; X64-NEXT: .LBB1_2: # %bb2
+; X64-NEXT: retq
+bb:
+ %call = tail call i1 @llvm.type.test(ptr null, metadata !"typeinfo")
+ br i1 %call, label %bb2, label %bb1
+
+bb1:
+ tail call void @llvm.ubsantrap(i8 2)
+ unreachable
+
+bb2:
+ ret void
+}
+
+declare i1 @llvm.public.type.test(ptr, metadata)
+
+declare void @llvm.assume(i1 noundef)
+
+declare i1 @llvm.type.test(ptr, metadata)
+
+declare void @llvm.ubsantrap(i8 immarg)
|
arsenm
reviewed
Jun 5, 2025
llvm/test/CodeGen/X86/pr142937.ll
Outdated
Comment on lines
2
to
3
| ; RUN: llc < %s -mtriple=i686-- -opt-bisect-limit=0 | FileCheck %s --check-prefix=X86 | ||
| ; RUN: llc < %s -mtriple=x86_64-- -opt-bisect-limit=0 | FileCheck %s --check-prefix=X64 |
There was a problem hiding this comment.
Do not use -opt-bisect-limit in tests
There was a problem hiding this comment.
Changed to use -O0 instead
Comment on lines
7390
to
7399
| if (const auto *call = dyn_cast<CallInst>(U)) { | ||
| return call->getIntrinsicID() == Intrinsic::assume; | ||
| } | ||
| return false; | ||
| }); | ||
|
|
||
| if (AllUsersAreAssume) | ||
| setValue(&I, DAG.getUNDEF(MVT::i1)); | ||
| else | ||
| setValue(&I, DAG.getConstant(1, sdl, MVT::i1)); |
There was a problem hiding this comment.
Why do you need to specifically look at the uses? Why can't you just unconditionally lower it to undef?
There was a problem hiding this comment.
Wouldn't there be a problem when the value is used in branches?
%call = tail call i1 @llvm.type.test(ptr null, metadata !"typeinfo")
br i1 %call, label %bb2, label %bb1
There was a problem hiding this comment.
I've changed it to always have a true value, so that we don't have false alarms when bisecting.
e-kud
reviewed
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142937