Skip to content

Revert "Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags" #142318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

vitalybuka
Copy link
Collaborator

Reverts #142210

This is not enough, see #141664

@llvmbot llvmbot added the mlir label Jun 1, 2025
@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Jun 1, 2025
@vitalybuka vitalybuka merged commit 002c0ab into main Jun 1, 2025
9 of 14 checks passed
@vitalybuka vitalybuka deleted the revert-142210-hash/fix-testing branch June 1, 2025 20:45
@llvmbot
Copy link
Member

llvmbot commented Jun 1, 2025

@llvm/pr-subscribers-mlir

Author: Vitaly Buka (vitalybuka)

Changes

Reverts llvm/llvm-project#142210

This is not enough, see #141664


Full diff: https://github.com/llvm/llvm-project/pull/142318.diff

1 Files Affected:

  • (modified) mlir/unittests/IR/OperationSupportTest.cpp (+2-2)
diff --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index 18ee9d71cb9fc..b18512817969e 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@ TEST(OperationEquivalenceTest, HashWorksWithFlags) {
   auto req2 = b.getI32IntegerAttr(60);
   Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
       b.getUnknownLoc(), req2, nullptr, nullptr, req2);
+  EXPECT_NE(getHash(op1, OperationEquivalence::None),
+            getHash(op2, OperationEquivalence::None));
   EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
             getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
-  EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
-            getHash(opWithProperty2, OperationEquivalence::None));
   opWithProperty1->destroy();
   opWithProperty2->destroy();
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants