Fixed wrong check OperationEquivalenceTest.HashWorksWithFlags

[AviadCo]

The check was meant to check IgnoreProperties works as expected but operated on the wrong operation.

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Aviad Cohen (AviadCo)

Changes

The check was meant to check IgnoreProperties works as expected but operated on the wrong operation.

---

Full diff: https://github.com/llvm/llvm-project/pull/142210.diff

1 Files Affected:

• (modified) mlir/unittests/IR/OperationSupportTest.cpp (+2-2)

diff --git a/mlir/unittests/IR/OperationSupportTest.cpp b/mlir/unittests/IR/OperationSupportTest.cpp
index b18512817969e..18ee9d71cb9fc 100644
--- a/mlir/unittests/IR/OperationSupportTest.cpp
+++ b/mlir/unittests/IR/OperationSupportTest.cpp
@@ -350,10 +350,10 @@ TEST(OperationEquivalenceTest, HashWorksWithFlags) {
   auto req2 = b.getI32IntegerAttr(60);
   Operation *opWithProperty2 = b.create<test::OpAttrMatch1>(
       b.getUnknownLoc(), req2, nullptr, nullptr, req2);
-  EXPECT_NE(getHash(op1, OperationEquivalence::None),
-            getHash(op2, OperationEquivalence::None));
   EXPECT_EQ(getHash(opWithProperty1, OperationEquivalence::IgnoreProperties),
             getHash(opWithProperty2, OperationEquivalence::IgnoreProperties));
+  EXPECT_NE(getHash(opWithProperty1, OperationEquivalence::None),
+            getHash(opWithProperty2, OperationEquivalence::None));
   opWithProperty1->destroy();
   opWithProperty2->destroy();
 }

[AviadCo]

@krzysz00 this small PR fixes wrongly check in #141664 PR (discovered by ASAN due to calling destroy to op1 & op2 twice in OperationEquivalenceTest.HashWorksWithFlags