[LLDB] Remove redundant check in DemangledNameInfo::hasBasename #142139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) ChangesThis patch removes a redundant check in DemangledNameInfo::hasBasename. Since the start and end range are unsigned, if end > start, then end is always greater than 0. Full diff: https://github.com/llvm/llvm-project/pull/142139.diff 1 Files Affected:
diff --git a/lldb/include/lldb/Core/DemangledNameInfo.h b/lldb/include/lldb/Core/DemangledNameInfo.h
index ab9bb3e211b66..4b5ba5e42b3b1 100644
--- a/lldb/include/lldb/Core/DemangledNameInfo.h
+++ b/lldb/include/lldb/Core/DemangledNameInfo.h
@@ -71,8 +71,7 @@ struct DemangledNameInfo {
/// Returns \c true if this object holds a valid basename range.
bool hasBasename() const {
- return BasenameRange.second > BasenameRange.first &&
- BasenameRange.second > 0;
+ return BasenameRange.second > BasenameRange.first;
}
};
|
charles-zablit
added a commit
to swiftlang/llvm-project
that referenced
this pull request
May 30, 2025
adrian-prantl
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 3, 2025
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a redundant check in DemangledNameInfo::hasBasename.
Since the start and end range are unsigned, if end > start, then end is always greater than 0.