[Syntax Highlighting] Add name and parameters syntax highlighting in Swift backtraces #10710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds function name syntax highlighting in LLDB Swift backtraces.
Motivation
In this patch, @Michael137 implemented name highlighting for methods in the C++ plugin of LLDB. This results in better readability when reading backtraces of functions with long scopes.
Please find below an example of the same feature, ported to Swift (which this patch implements):

Before:
After:

Implementation details
swiftlang/swift#81511 implements a way to override the
NodePrinter
, which allows to track relevant ranges. Once the correct ranges are tracked, we return a slice of the demangled string for the relevant part of the highlighting query.The rest of the implementation is a close copy of @Michael137 's work.
Testing
The tests are implemented using the
manglings.txt
file in the swift repo.Follow ups
prefix
andsuffix
ranges. We could track those ranges as well to grey out some information that are not important, eg the fact the function is fileprivate.