[X86] Return from SimplifyDemandedBitsForTargetNode for X86ISD::CMOV/ANDP after computing KnownBits. NFC #141992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ANDP after computing KnownBits. NFC If we break out of the switch, I believe we fall back to the generic SimplifyDemandedBitsForTargetNode which will call computeKnownBitsForTargetNode. This will recurse again and calculate it's own KnownBits. Since we already did the recursion, we should keep the results.
|
@llvm/pr-subscribers-backend-x86 Author: Craig Topper (topperc) ChangesIf we break out of the switch, I believe we fall back to the generic SimplifyDemandedBitsForTargetNode which will call computeKnownBitsForTargetNode. This will recurse again and calculate it's own KnownBits. Since we already did the recursion, we should keep the results. Full diff: https://github.com/llvm/llvm-project/pull/141992.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 6b71f49165c60..ecadc86a0b781 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -44789,7 +44789,7 @@ bool X86TargetLowering::SimplifyDemandedBitsForTargetNode(
// Only known if known in both the LHS and RHS.
Known = Known.intersectWith(Known2);
- break;
+ return false;
}
case X86ISD::BEXTR:
case X86ISD::BEXTRI: {
|
svkeerthy
pushed a commit
that referenced
this pull request
May 29, 2025
…ANDP after computing KnownBits. NFC (#141992) If we break out of the switch, I believe we fall back to the generic SimplifyDemandedBitsForTargetNode which will call computeKnownBitsForTargetNode. This will recurse again and calculate it's own KnownBits. Since we already did the recursion, we should keep the results.
google-yfyang
pushed a commit
to google-yfyang/llvm-project
that referenced
this pull request
May 29, 2025
…ANDP after computing KnownBits. NFC (llvm#141992) If we break out of the switch, I believe we fall back to the generic SimplifyDemandedBitsForTargetNode which will call computeKnownBitsForTargetNode. This will recurse again and calculate it's own KnownBits. Since we already did the recursion, we should keep the results.
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
…ANDP after computing KnownBits. NFC (llvm#141992) If we break out of the switch, I believe we fall back to the generic SimplifyDemandedBitsForTargetNode which will call computeKnownBitsForTargetNode. This will recurse again and calculate it's own KnownBits. Since we already did the recursion, we should keep the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we break out of the switch, I believe we fall back to the generic SimplifyDemandedBitsForTargetNode which will call computeKnownBitsForTargetNode. This will recurse again and calculate it's own KnownBits. Since we already did the recursion, we should keep the results.