-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[mlir][gpu] Fix breaking constructor from GPUSubgroupSizeToROCDL #137439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We are adding GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing said error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <stanley.winata@amd.com>
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-gpu Author: Stanley Winata (raikonenfnu) ChangesWe are adding GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing said error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Full diff: https://github.com/llvm/llvm-project/pull/137439.diff 1 Files Affected:
diff --git a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
index 0a6fb6451f700..dd16ec4b73e9f 100644
--- a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+++ b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
@@ -455,9 +455,7 @@ void mlir::populateGpuToROCDLConversionPatterns(
// TODO: Add alignment for workgroup memory
patterns.add<GPUDynamicSharedMemoryOpLowering>(converter);
- patterns
- .add<GPUShuffleOpLowering, GPULaneIdOpToROCDL, GPUSubgroupSizeOpToROCDL>(
- converter);
+ patterns.add<GPUShuffleOpLowering, GPULaneIdOpToROCDL>(converter);
patterns.add<GPUSubgroupSizeOpToROCDL>(converter, chipset);
populateMathToROCDLConversionPatterns(converter, patterns);
|
Thank you for fixing this! |
…m#137439) This PR addressed a bug from llvm#137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <stanley.winata@amd.com>
…m#137439) This PR addressed a bug from llvm#137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <stanley.winata@amd.com>
…m#137439) This PR addressed a bug from llvm#137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <stanley.winata@amd.com>
…m#137439) This PR addressed a bug from llvm#137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <stanley.winata@amd.com>
…m#137439) This PR addressed a bug from llvm#137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below: error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly deleted Signed-off-by: Stanley Winata <stanley.winata@amd.com>
This PR addressed a bug from #137360. which was using GPUSubgroupSizeToROCDL to patterns function that do not have a valid constructor for it. This is causing compilation error below:
error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base class 'ConvertOpToLLVMPatternmlir::gpu::SubgroupSizeOp' is implicitly deleted