[llvm] Use masm for UEFI #132461
Merged
[llvm] Use masm for UEFI #132461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For UEFI targets use Microsoft masm.
|
@llvm/pr-subscribers-backend-x86 Author: Prabhuk (OOO till April 2nd Week) (Prabhuk) ChangesFor UEFI targets use Microsoft masm. Full diff: https://github.com/llvm/llvm-project/pull/132461.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
index ad94e306f339e..9d86f8eb91506 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
@@ -444,7 +444,7 @@ static MCAsmInfo *createX86MCAsmInfo(const MCRegisterInfo &MRI,
// Force the use of an ELF container.
MAI = new X86ELFMCAsmInfo(TheTriple);
} else if (TheTriple.isWindowsMSVCEnvironment() ||
- TheTriple.isWindowsCoreCLREnvironment()) {
+ TheTriple.isWindowsCoreCLREnvironment() || TheTriple.isUEFI()) {
if (Options.getAssemblyLanguage().equals_insensitive("masm"))
MAI = new X86MCAsmInfoMicrosoftMASM(TheTriple);
else
|
petrhosek
approved these changes
Apr 18, 2025
|
Can you remove the second UEFI case? llvm-project/llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp Lines 455 to 457 in 8eb73d0 |
Prabhuk
added a commit
to Prabhuk/llvm-project
that referenced
this pull request
Apr 21, 2025
In `X86MCTargetDesc.cpp` while fixing the handling of UEFI target in the `createX86MCAsmInfo` function (llvm#132461), the previous incorrect handling of isUEFI was not removed. This patch cleans up that case.
Prabhuk
added a commit
that referenced
this pull request
Apr 22, 2025
In `X86MCTargetDesc.cpp` while fixing the handling of UEFI target in the `createX86MCAsmInfo` function (#132461), the previous incorrect handling of isUEFI was not removed. This patch cleans up that case.
Landed this cleanup as an NFC here: #136593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UEFI targets use Microsoft masm.