[Clang][OpenCL] Wrap image functions with the macro #129177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the OpenCL C spec, the image functions are optional. For OpenCL C 1.2, the image functions are guarded by the `__IMAGE_SUPPORT__` macro. For the OpenCL C 3.0 and later, the `__opencl_c_images` macro is used.
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-x86 Author: Victor Mustya (vmustya) ChangesAccording to the OpenCL C spec, the image functions are optional. Full diff: https://github.com/llvm/llvm-project/pull/129177.diff 1 Files Affected:
diff --git a/clang/lib/Headers/opencl-c.h b/clang/lib/Headers/opencl-c.h
index 20719b74b6b8d..8d8ef497cec49 100644
--- a/clang/lib/Headers/opencl-c.h
+++ b/clang/lib/Headers/opencl-c.h
@@ -15082,6 +15082,7 @@ half16 __ovld __cnfn shuffle2(half16, half16, ushort16);
#pragma OPENCL EXTENSION cl_khr_gl_msaa_sharing : enable
#endif //cl_khr_gl_msaa_sharing
+#if (defined(__opencl_c_images) || defined(__IMAGE_SUPPORT__))
/**
* Use the coordinate (coord.xy) to do an element lookup in
* the 2D image object specified by image.
@@ -16143,6 +16144,8 @@ int __ovld __cnfn get_image_num_samples(read_write image2d_array_msaa_depth_t);
#endif //defined(__opencl_c_read_write_images)
#endif
+#endif // (defined(__opencl_c_images) || defined(__IMAGE_SUPPORT__))
+
// OpenCL v2.0 s6.13.15 - Work-group Functions
#if defined(__opencl_c_work_group_collective_functions)
|
|
@llvm/pr-subscribers-clang Author: Victor Mustya (vmustya) ChangesAccording to the OpenCL C spec, the image functions are optional. Full diff: https://github.com/llvm/llvm-project/pull/129177.diff 1 Files Affected:
diff --git a/clang/lib/Headers/opencl-c.h b/clang/lib/Headers/opencl-c.h
index 20719b74b6b8d..8d8ef497cec49 100644
--- a/clang/lib/Headers/opencl-c.h
+++ b/clang/lib/Headers/opencl-c.h
@@ -15082,6 +15082,7 @@ half16 __ovld __cnfn shuffle2(half16, half16, ushort16);
#pragma OPENCL EXTENSION cl_khr_gl_msaa_sharing : enable
#endif //cl_khr_gl_msaa_sharing
+#if (defined(__opencl_c_images) || defined(__IMAGE_SUPPORT__))
/**
* Use the coordinate (coord.xy) to do an element lookup in
* the 2D image object specified by image.
@@ -16143,6 +16144,8 @@ int __ovld __cnfn get_image_num_samples(read_write image2d_array_msaa_depth_t);
#endif //defined(__opencl_c_read_write_images)
#endif
+#endif // (defined(__opencl_c_images) || defined(__IMAGE_SUPPORT__))
+
// OpenCL v2.0 s6.13.15 - Work-group Functions
#if defined(__opencl_c_work_group_collective_functions)
|
|
Hi @svenvh! I am adding you as a reviewer since you worked on the headers earlier. |
michalpaszkowski
approved these changes
Mar 2, 2025
svenvh
approved these changes
Mar 2, 2025
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
According to the OpenCL C spec, the image functions are optional. For OpenCL C 1.2, the image functions are guarded by the `__IMAGE_SUPPORT__` macro. For the OpenCL C 3.0 and later, the `__opencl_c_images` macro is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OpenCL C spec, the image functions are optional.
For OpenCL C 1.2, the image functions are guarded by the
__IMAGE_SUPPORT__macro. For the OpenCL C 3.0 and later, the__opencl_c_imagesmacro is used.