Skip to content

[M68k] ARII atomic load/store #108982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions llvm/lib/Target/M68k/M68kISelDAGToDAG.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -772,6 +772,20 @@ static bool isAddressBase(const SDValue &N) {
}
}

static bool AllowARIIWithZeroDisp(SDNode *Parent) {
if (!Parent)
return false;
switch (Parent->getOpcode()) {
case ISD::LOAD:
case ISD::STORE:
case ISD::ATOMIC_LOAD:
case ISD::ATOMIC_STORE:
return true;
default:
return false;
}
}

bool M68kDAGToDAGISel::SelectARII(SDNode *Parent, SDValue N, SDValue &Disp,
SDValue &Base, SDValue &Index) {
M68kISelAddressMode AM(M68kISelAddressMode::AddrType::ARII);
Expand Down Expand Up @@ -811,8 +825,7 @@ bool M68kDAGToDAGISel::SelectARII(SDNode *Parent, SDValue N, SDValue &Disp,
// The idea here is that we want to use AddrType::ARII without displacement
// only if necessary like memory operations, otherwise this must be lowered
// into addition
if (AM.Disp == 0 && (!Parent || (Parent->getOpcode() != ISD::LOAD &&
Parent->getOpcode() != ISD::STORE))) {
if (AM.Disp == 0 && !AllowARIIWithZeroDisp(Parent)) {
LLVM_DEBUG(dbgs() << "REJECT: Displacement is Zero\n");
return false;
}
Expand Down
7 changes: 7 additions & 0 deletions llvm/lib/Target/M68k/M68kInstrAtomics.td
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,16 @@ foreach size = [8, 16, 32] in {
def : Pat<(!cast<SDPatternOperator>("atomic_load_"#size) MxCP_ARI:$ptr),
(!cast<MxInst>("MOV"#size#"dj") !cast<MxMemOp>("MxARI"#size):$ptr)>;

def : Pat<(!cast<SDPatternOperator>("atomic_load_"#size) MxCP_ARII:$ptr),
(!cast<MxInst>("MOV"#size#"df") !cast<MxMemOp>("MxARII"#size):$ptr)>;

def : Pat<(!cast<SDPatternOperator>("atomic_store_"#size) !cast<MxRegOp>("MxDRD"#size):$val, MxCP_ARI:$ptr),
(!cast<MxInst>("MOV"#size#"jd") !cast<MxMemOp>("MxARI"#size):$ptr,
!cast<MxRegOp>("MxDRD"#size):$val)>;

def : Pat<(!cast<SDPatternOperator>("atomic_store_"#size) !cast<MxRegOp>("MxDRD"#size):$val, MxCP_ARII:$ptr),
(!cast<MxInst>("MOV"#size#"fd") !cast<MxMemOp>("MxARII"#size):$ptr,
!cast<MxRegOp>("MxDRD"#size):$val)>;
}

let Predicates = [AtLeastM68020] in {
Expand Down
46 changes: 46 additions & 0 deletions llvm/test/CodeGen/M68k/Atomics/non-ari.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
; RUN: llc %s -o - -mtriple=m68k -mcpu=M68000 | FileCheck %s --check-prefix=NO-ATOMIC
; RUN: llc %s -o - -mtriple=m68k -mcpu=M68010 | FileCheck %s --check-prefix=NO-ATOMIC
; RUN: llc %s -o - -mtriple=m68k -mcpu=M68020 | FileCheck %s --check-prefix=ATOMIC
; RUN: llc %s -o - -mtriple=m68k -mcpu=M68030 | FileCheck %s --check-prefix=ATOMIC
; RUN: llc %s -o - -mtriple=m68k -mcpu=M68040 | FileCheck %s --check-prefix=ATOMIC

define void @atomic_store_i8_element_monotonic(i8 %val, ptr %base, i32 %offset) nounwind {
; NO-ATOMIC-LABEL: atomic_store_i8_element_monotonic:
; NO-ATOMIC: ; %bb.0:
; NO-ATOMIC-NEXT: move.b (7,%sp), %d0
; NO-ATOMIC-NEXT: move.l (12,%sp), %d1
; NO-ATOMIC-NEXT: move.l (8,%sp), %a0
; NO-ATOMIC-NEXT: move.b %d0, (0,%a0,%d1)
; NO-ATOMIC-NEXT: rts
;
; ATOMIC-LABEL: atomic_store_i8_element_monotonic:
; ATOMIC: ; %bb.0:
; ATOMIC-NEXT: move.b (7,%sp), %d0
; ATOMIC-NEXT: move.l (12,%sp), %d1
; ATOMIC-NEXT: move.l (8,%sp), %a0
; ATOMIC-NEXT: move.b %d0, (0,%a0,%d1)
; ATOMIC-NEXT: rts
%store_pointer = getelementptr i8, ptr %base, i32 %offset
store atomic i8 %val, ptr %store_pointer monotonic, align 1
ret void
}

define i8 @atomic_load_i8_element_monotonic(ptr %base, i32 %offset) nounwind {
; NO-ATOMIC-LABEL: atomic_load_i8_element_monotonic:
; NO-ATOMIC: ; %bb.0:
; NO-ATOMIC-NEXT: move.l (8,%sp), %d0
; NO-ATOMIC-NEXT: move.l (4,%sp), %a0
; NO-ATOMIC-NEXT: move.b (0,%a0,%d0), %d0
; NO-ATOMIC-NEXT: rts
;
; ATOMIC-LABEL: atomic_load_i8_element_monotonic:
; ATOMIC: ; %bb.0:
; ATOMIC-NEXT: move.l (8,%sp), %d0
; ATOMIC-NEXT: move.l (4,%sp), %a0
; ATOMIC-NEXT: move.b (0,%a0,%d0), %d0
; ATOMIC-NEXT: rts
%load_pointer = getelementptr i8, ptr %base, i32 %offset
%return_val = load atomic i8, ptr %load_pointer monotonic, align 1
ret i8 %return_val
}
Loading