Skip to content

[AMDGPU] Create dir for amdgpu specific machineverifier tests #106960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

AditiRM
Copy link
Member

@AditiRM AditiRM commented Sep 2, 2024

Move the AMDGPU target specific testcases in MachineVerifier separately into new directory.
Reference : #105494 (comment)

@AditiRM AditiRM self-assigned this Sep 2, 2024
@AditiRM AditiRM marked this pull request as ready for review September 2, 2024 09:54
@llvmbot
Copy link
Member

llvmbot commented Sep 2, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Aditi Medhane (AditiRM)

Changes

Move the AMDGPU target specific testcases in MachineVerifier separately into new directory.


Full diff: https://github.com/llvm/llvm-project/pull/106960.diff

13 Files Affected:

  • (renamed) llvm/test/MachineVerifier/amdgpu/register-killed-inside-loop.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/test_g_bitcast.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/test_g_intrinsic.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/test_g_intrinsic_w_side_effects.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/undef-should-only-be-set-on-subreg-defs.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/undef-virt-reg-entry-block.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/undef-virt-reg-nonentry-block.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/verifier-ec-subreg-liveness.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/verifier-implicit-virtreg-invalid-physreg-liveness.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/verifier-pseudo-terminators.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/verify-implicit-def.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/verify-reg-sequence.mir ()
  • (renamed) llvm/test/MachineVerifier/amdgpu/writelane_m0.mir ()
diff --git a/llvm/test/MachineVerifier/register-killed-inside-loop.mir b/llvm/test/MachineVerifier/amdgpu/register-killed-inside-loop.mir
similarity index 100%
rename from llvm/test/MachineVerifier/register-killed-inside-loop.mir
rename to llvm/test/MachineVerifier/amdgpu/register-killed-inside-loop.mir
diff --git a/llvm/test/MachineVerifier/test_g_bitcast.mir b/llvm/test/MachineVerifier/amdgpu/test_g_bitcast.mir
similarity index 100%
rename from llvm/test/MachineVerifier/test_g_bitcast.mir
rename to llvm/test/MachineVerifier/amdgpu/test_g_bitcast.mir
diff --git a/llvm/test/MachineVerifier/test_g_intrinsic.mir b/llvm/test/MachineVerifier/amdgpu/test_g_intrinsic.mir
similarity index 100%
rename from llvm/test/MachineVerifier/test_g_intrinsic.mir
rename to llvm/test/MachineVerifier/amdgpu/test_g_intrinsic.mir
diff --git a/llvm/test/MachineVerifier/test_g_intrinsic_w_side_effects.mir b/llvm/test/MachineVerifier/amdgpu/test_g_intrinsic_w_side_effects.mir
similarity index 100%
rename from llvm/test/MachineVerifier/test_g_intrinsic_w_side_effects.mir
rename to llvm/test/MachineVerifier/amdgpu/test_g_intrinsic_w_side_effects.mir
diff --git a/llvm/test/MachineVerifier/undef-should-only-be-set-on-subreg-defs.mir b/llvm/test/MachineVerifier/amdgpu/undef-should-only-be-set-on-subreg-defs.mir
similarity index 100%
rename from llvm/test/MachineVerifier/undef-should-only-be-set-on-subreg-defs.mir
rename to llvm/test/MachineVerifier/amdgpu/undef-should-only-be-set-on-subreg-defs.mir
diff --git a/llvm/test/MachineVerifier/undef-virt-reg-entry-block.mir b/llvm/test/MachineVerifier/amdgpu/undef-virt-reg-entry-block.mir
similarity index 100%
rename from llvm/test/MachineVerifier/undef-virt-reg-entry-block.mir
rename to llvm/test/MachineVerifier/amdgpu/undef-virt-reg-entry-block.mir
diff --git a/llvm/test/MachineVerifier/undef-virt-reg-nonentry-block.mir b/llvm/test/MachineVerifier/amdgpu/undef-virt-reg-nonentry-block.mir
similarity index 100%
rename from llvm/test/MachineVerifier/undef-virt-reg-nonentry-block.mir
rename to llvm/test/MachineVerifier/amdgpu/undef-virt-reg-nonentry-block.mir
diff --git a/llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir b/llvm/test/MachineVerifier/amdgpu/verifier-ec-subreg-liveness.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir
rename to llvm/test/MachineVerifier/amdgpu/verifier-ec-subreg-liveness.mir
diff --git a/llvm/test/MachineVerifier/verifier-implicit-virtreg-invalid-physreg-liveness.mir b/llvm/test/MachineVerifier/amdgpu/verifier-implicit-virtreg-invalid-physreg-liveness.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verifier-implicit-virtreg-invalid-physreg-liveness.mir
rename to llvm/test/MachineVerifier/amdgpu/verifier-implicit-virtreg-invalid-physreg-liveness.mir
diff --git a/llvm/test/MachineVerifier/verifier-pseudo-terminators.mir b/llvm/test/MachineVerifier/amdgpu/verifier-pseudo-terminators.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verifier-pseudo-terminators.mir
rename to llvm/test/MachineVerifier/amdgpu/verifier-pseudo-terminators.mir
diff --git a/llvm/test/MachineVerifier/verify-implicit-def.mir b/llvm/test/MachineVerifier/amdgpu/verify-implicit-def.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verify-implicit-def.mir
rename to llvm/test/MachineVerifier/amdgpu/verify-implicit-def.mir
diff --git a/llvm/test/MachineVerifier/verify-reg-sequence.mir b/llvm/test/MachineVerifier/amdgpu/verify-reg-sequence.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verify-reg-sequence.mir
rename to llvm/test/MachineVerifier/amdgpu/verify-reg-sequence.mir
diff --git a/llvm/test/MachineVerifier/writelane_m0.mir b/llvm/test/MachineVerifier/amdgpu/writelane_m0.mir
similarity index 100%
rename from llvm/test/MachineVerifier/writelane_m0.mir
rename to llvm/test/MachineVerifier/amdgpu/writelane_m0.mir

@jayfoad
Copy link
Contributor

jayfoad commented Sep 2, 2024

Please make the amdgpu directory name upper case, like everywhere else in test/.

Also it would be good to remove REQUIRES: amdgpu-registered-target from each individual test and into a lit.local.cfg but I guess that could be done in a follow up.

@AditiRM AditiRM requested a review from jayfoad September 2, 2024 11:26
Introduced AMDGPU directory and lit.local.cfg accordingly
@AditiRM
Copy link
Member Author

AditiRM commented Sep 3, 2024

@jayfoad Please review the latest changes as per suggestions.

Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AditiRM AditiRM merged commit d24a2fd into llvm:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants