-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[AMDGPU] Create dir for amdgpu specific machineverifier tests #106960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-backend-amdgpu Author: Aditi Medhane (AditiRM) ChangesMove the AMDGPU target specific testcases in MachineVerifier separately into new directory. Full diff: https://github.com/llvm/llvm-project/pull/106960.diff 13 Files Affected:
diff --git a/llvm/test/MachineVerifier/register-killed-inside-loop.mir b/llvm/test/MachineVerifier/amdgpu/register-killed-inside-loop.mir
similarity index 100%
rename from llvm/test/MachineVerifier/register-killed-inside-loop.mir
rename to llvm/test/MachineVerifier/amdgpu/register-killed-inside-loop.mir
diff --git a/llvm/test/MachineVerifier/test_g_bitcast.mir b/llvm/test/MachineVerifier/amdgpu/test_g_bitcast.mir
similarity index 100%
rename from llvm/test/MachineVerifier/test_g_bitcast.mir
rename to llvm/test/MachineVerifier/amdgpu/test_g_bitcast.mir
diff --git a/llvm/test/MachineVerifier/test_g_intrinsic.mir b/llvm/test/MachineVerifier/amdgpu/test_g_intrinsic.mir
similarity index 100%
rename from llvm/test/MachineVerifier/test_g_intrinsic.mir
rename to llvm/test/MachineVerifier/amdgpu/test_g_intrinsic.mir
diff --git a/llvm/test/MachineVerifier/test_g_intrinsic_w_side_effects.mir b/llvm/test/MachineVerifier/amdgpu/test_g_intrinsic_w_side_effects.mir
similarity index 100%
rename from llvm/test/MachineVerifier/test_g_intrinsic_w_side_effects.mir
rename to llvm/test/MachineVerifier/amdgpu/test_g_intrinsic_w_side_effects.mir
diff --git a/llvm/test/MachineVerifier/undef-should-only-be-set-on-subreg-defs.mir b/llvm/test/MachineVerifier/amdgpu/undef-should-only-be-set-on-subreg-defs.mir
similarity index 100%
rename from llvm/test/MachineVerifier/undef-should-only-be-set-on-subreg-defs.mir
rename to llvm/test/MachineVerifier/amdgpu/undef-should-only-be-set-on-subreg-defs.mir
diff --git a/llvm/test/MachineVerifier/undef-virt-reg-entry-block.mir b/llvm/test/MachineVerifier/amdgpu/undef-virt-reg-entry-block.mir
similarity index 100%
rename from llvm/test/MachineVerifier/undef-virt-reg-entry-block.mir
rename to llvm/test/MachineVerifier/amdgpu/undef-virt-reg-entry-block.mir
diff --git a/llvm/test/MachineVerifier/undef-virt-reg-nonentry-block.mir b/llvm/test/MachineVerifier/amdgpu/undef-virt-reg-nonentry-block.mir
similarity index 100%
rename from llvm/test/MachineVerifier/undef-virt-reg-nonentry-block.mir
rename to llvm/test/MachineVerifier/amdgpu/undef-virt-reg-nonentry-block.mir
diff --git a/llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir b/llvm/test/MachineVerifier/amdgpu/verifier-ec-subreg-liveness.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verifier-ec-subreg-liveness.mir
rename to llvm/test/MachineVerifier/amdgpu/verifier-ec-subreg-liveness.mir
diff --git a/llvm/test/MachineVerifier/verifier-implicit-virtreg-invalid-physreg-liveness.mir b/llvm/test/MachineVerifier/amdgpu/verifier-implicit-virtreg-invalid-physreg-liveness.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verifier-implicit-virtreg-invalid-physreg-liveness.mir
rename to llvm/test/MachineVerifier/amdgpu/verifier-implicit-virtreg-invalid-physreg-liveness.mir
diff --git a/llvm/test/MachineVerifier/verifier-pseudo-terminators.mir b/llvm/test/MachineVerifier/amdgpu/verifier-pseudo-terminators.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verifier-pseudo-terminators.mir
rename to llvm/test/MachineVerifier/amdgpu/verifier-pseudo-terminators.mir
diff --git a/llvm/test/MachineVerifier/verify-implicit-def.mir b/llvm/test/MachineVerifier/amdgpu/verify-implicit-def.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verify-implicit-def.mir
rename to llvm/test/MachineVerifier/amdgpu/verify-implicit-def.mir
diff --git a/llvm/test/MachineVerifier/verify-reg-sequence.mir b/llvm/test/MachineVerifier/amdgpu/verify-reg-sequence.mir
similarity index 100%
rename from llvm/test/MachineVerifier/verify-reg-sequence.mir
rename to llvm/test/MachineVerifier/amdgpu/verify-reg-sequence.mir
diff --git a/llvm/test/MachineVerifier/writelane_m0.mir b/llvm/test/MachineVerifier/amdgpu/writelane_m0.mir
similarity index 100%
rename from llvm/test/MachineVerifier/writelane_m0.mir
rename to llvm/test/MachineVerifier/amdgpu/writelane_m0.mir
|
Please make the Also it would be good to remove |
Introduced AMDGPU directory and lit.local.cfg accordingly
@jayfoad Please review the latest changes as per suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Move the AMDGPU target specific testcases in MachineVerifier separately into new directory.
Reference : #105494 (comment)