[AVR] Fix 16-bit LDDs with immediate overflows #104923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @benshi001 🙂 |
|
LGTM, thanks! |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 2, 2024
16-bit loads are expanded into a pair of 8-bit loads, so the maximum offset of such 16-bit loads must be 62, not 63. (cherry picked from commit c7a4efa)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 24, 2024
16-bit loads are expanded into a pair of 8-bit loads, so the maximum offset of such 16-bit loads must be 62, not 63. (cherry picked from commit c7a4efa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16-bit loads are expanded into a pair of 8-bit loads, so a maximum offset of such load must be 62, not 63 - our current logic doesn't handle it properly and triggers:
llvm-project/llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp
Line 780 in 2511cdb
... which this commit fixes.
Spotted in the wild at Rahix/avr-hal#573.