-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "[AVR] Fix 16-bit LDDs with immediate overflows (#104923)" #106946
Comments
Error: Command failed due to missing milestone. |
fwiw, it needs to be cherry-picked into https://github.com/rust-lang/llvm-project (https://rustc-dev-guide.rust-lang.org/backend/updating-llvm.html) to actually land in rustc. I was planning on doing that later, since we've gotta bundle that commit together with #106729 to actually get the codegen working. |
Yeah I know, but the dev guide says to request a backport upstream first, so I figured I'd do that.
Ah okay; is there anything at all that I can do? 🙂 |
Added the milestone, let's see whether it helps. |
/cherry-pick c7a4efa |
/pull-request #106993 |
/cherry-pick c7a4efa
I initially spotted and reported the bug here: Rahix/avr-hal#573
Thanks to @Patryk27 there's a fix that has even been merged already, but I really need this to make its way into a Rust toolchain 🙂
So I did some digging and basically copied #106728 and am hereby requesting a backport of this into the release branch. Hope I'm doing this right! Thanks!
Edit: looks like I'm unable to set the correct milestone, any help? 🙏
The text was updated successfully, but these errors were encountered: