Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "[AVR] Fix 16-bit LDDs with immediate overflows (#104923)" #106946

Closed
tronje opened this issue Sep 2, 2024 · 7 comments
Closed

Backport "[AVR] Fix 16-bit LDDs with immediate overflows (#104923)" #106946

tronje opened this issue Sep 2, 2024 · 7 comments

Comments

@tronje
Copy link

tronje commented Sep 2, 2024

/cherry-pick c7a4efa

I initially spotted and reported the bug here: Rahix/avr-hal#573
Thanks to @Patryk27 there's a fix that has even been merged already, but I really need this to make its way into a Rust toolchain 🙂
So I did some digging and basically copied #106728 and am hereby requesting a backport of this into the release branch. Hope I'm doing this right! Thanks!

Edit: looks like I'm unable to set the correct milestone, any help? 🙏

@llvmbot
Copy link
Collaborator

llvmbot commented Sep 2, 2024

/cherry-pick c7a4efa

I initially spotted and reported the bug here: Rahix/avr-hal#573
Thanks to @Patryk27 there's a fix that has even been merged already, but I really need this to make its way into a Rust toolchain 🙂
So I did some digging and basically copied #106728 and am hereby requesting a backport of this into the release branch. Hope I'm doing this right! Thanks!

Error: Command failed due to missing milestone.

@Patryk27
Copy link
Contributor

Patryk27 commented Sep 2, 2024

fwiw, it needs to be cherry-picked into https://github.com/rust-lang/llvm-project (https://rustc-dev-guide.rust-lang.org/backend/updating-llvm.html) to actually land in rustc.

I was planning on doing that later, since we've gotta bundle that commit together with #106729 to actually get the codegen working.

@tronje
Copy link
Author

tronje commented Sep 2, 2024

fwiw, it needs to be cherry-picked into https://github.com/rust-lang/llvm-project (https://rustc-dev-guide.rust-lang.org/backend/updating-llvm.html) to actually land in rustc.

Yeah I know, but the dev guide says to request a backport upstream first, so I figured I'd do that.

I was planning on doing that later, since we've gotta bundle that commit together with #106729 to actually get the codegen working.

Ah okay; is there anything at all that I can do? 🙂

@Patryk27
Copy link
Contributor

Patryk27 commented Sep 2, 2024

Not sure, probably @aykevl can help us the most here - could you backport #104923? 😄

It looks like we're just missing the milestone label here, but I'm not sure on the backporting process.

@aykevl aykevl added this to the LLVM 19.X Release milestone Sep 2, 2024
@aykevl
Copy link
Contributor

aykevl commented Sep 2, 2024

Added the milestone, let's see whether it helps.

@EugeneZelenko
Copy link
Contributor

/cherry-pick c7a4efa

@llvmbot llvmbot closed this as completed Sep 2, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 2, 2024

/pull-request #106993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants