Skip to content

Conversation

@sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jul 3, 2023

Stack from ghstack (oldest at bottom):

Essentially converts a cir.loop op of the while kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

[ghstack-poisoned]
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

[ghstack-poisoned]
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

[ghstack-poisoned]
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

[ghstack-poisoned]
@sitio-couto sitio-couto merged commit a12089f into gh/sitio-couto/39/base Jul 5, 2023
sitio-couto added a commit that referenced this pull request Jul 5, 2023
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
@sitio-couto sitio-couto deleted the gh/sitio-couto/39/head branch July 5, 2023 21:13
lanza pushed a commit that referenced this pull request Jul 6, 2023
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
lanza pushed a commit that referenced this pull request Oct 27, 2023
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
lanza pushed a commit that referenced this pull request Dec 20, 2023
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
lanza pushed a commit that referenced this pull request Jan 29, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
lanza pushed a commit that referenced this pull request Mar 23, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: llvm#145
lanza pushed a commit that referenced this pull request Apr 27, 2024
This adds
- `emitc.global` and `emitc.get_global` ops to model global variables
similar to how `memref.global` and `memref.get_global` work.
- translation of those ops to C++
- lowering of `memref.global` and `memref.get_global` into those ops

---------

Co-authored-by: Simon Camphausen <simon.camphausen@iml.fraunhofer.de>
lanza pushed a commit that referenced this pull request Apr 29, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
lanza pushed a commit that referenced this pull request Apr 29, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: llvm#145
lanza pushed a commit that referenced this pull request Apr 29, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d262436d11d70fb6d2be23b63ba37ed01b9c1f
Pull Request resolved: llvm/clangir#145
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: llvm#145
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: llvm#145
lanza pushed a commit that referenced this pull request Nov 5, 2024
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
lanza pushed a commit that referenced this pull request Mar 18, 2025
Essentially converts a `cir.loop` op of the `while` kind to a CFG. The
implementation, however, was only tested with structured loops, so if
breaks, continues, or returns are found in the body, it is likely to
break.

ghstack-source-id: 32d2624
Pull Request resolved: #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants