Skip to content

[CIR][Lowering] Handle empty scope operations #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2023
Merged

[CIR][Lowering] Handle empty scope operations #144

merged 3 commits into from
Jul 5, 2023

Conversation

@sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jul 3, 2023 •
edited
Loading

@sitio-couto
[CIR][Lowering] Handle empty scope operations
d6a8d5a 
Guards cir.scope lowering against empty scopes avoiding segfaults.

[ghstack-poisoned]
This was referenced Jul 3, 2023
Merged
Merged
Merged
bcardosolopes
bcardosolopes approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment

@sitio-couto
Update on "[CIR][Lowering] Handle empty scope operations"
b03d4be 
Guards cir.scope lowering against empty scopes avoiding segfaults.

[ghstack-poisoned]
bcardosolopes
bcardosolopes approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tks!

@sitio-couto
Update on "[CIR][Lowering] Handle empty scope operations"
68aef09 
Guards cir.scope lowering against empty scopes avoiding segfaults.

[ghstack-poisoned]
@sitio-couto sitio-couto merged commit 68aef09 into gh/sitio-couto/38/base Jul 5, 2023
sitio-couto added a commit that referenced this pull request Jul 5, 2023
@sitio-couto
[CIR][Lowering] Handle empty scope operations
250c199 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
@sitio-couto sitio-couto deleted the gh/sitio-couto/38/head branch July 5, 2023 21:13
lanza pushed a commit that referenced this pull request Jul 6, 2023
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
2124a3e 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
lanza pushed a commit that referenced this pull request Oct 27, 2023
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
92222c8 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
lanza pushed a commit that referenced this pull request Dec 20, 2023
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
a1d7a99 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
9937fc3 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
ab4089a 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
6edd374 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: llvm#144
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
41e1cd6 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
3d57faf 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
7f14e5d 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: llvm#144
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
371e1d7 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
0a82909 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c4539552568d451ae0bf220ea6bde9a44fc66b8d
Pull Request resolved: llvm/clangir#144
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
9c30a73 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: llvm#144
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
30ad3d5 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: llvm#144
lanza pushed a commit that referenced this pull request Nov 5, 2024
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
1a3d634 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
lanza pushed a commit that referenced this pull request Mar 18, 2025
@sitio-couto @lanza
[CIR][Lowering] Handle empty scope operations
f63cbf2 
Guards cir.scope lowering against empty scopes avoiding segfaults.

Also removes empty cir.scope operations on MergeCleanups pass.

ghstack-source-id: c453955
Pull Request resolved: #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sitio-couto @bcardosolopes