[Handshake] Adding func instance op for integration #7812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mortbopet This is the op we discussed earlier today. Posting it without the lowering to get your eyes on it before you go on vacation. Will add the lowering before merging. |
teqdruid
force-pushed
the
teqdruid/handshake/esicall
branch
from
b8c3314
to
2f6db23
Compare
|
Some nit comments, but yep, this LGTM. I'm assuming this will lower to a |
Yep. Thanks! |
teqdruid
force-pushed
the
teqdruid/handshake/esicall
branch
from
2f6db23
to
adc9288
Compare
Actually, the DC lowering appears to be broken (#7818). I've added it instead to the HandshakeToHW lowering. Will add it to the DC on once that's fixed. |
Adds the ESIInstanceOp. This op allows a non-handshake design to instantiate `handshake.func`s. Since handshake needs elastic inputs and produces elastic outputs, this uses ESI channels.
teqdruid
force-pushed
the
teqdruid/handshake/esicall
branch
from
adc9288
to
bd53125
Compare
|
Will rely on post-merge feedback since @mortbopet is on vacation. |
Dinistro
reviewed
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ESIInstanceOp. This op allows a non-handshake design to instantiate
handshake.funcs. Since handshake needs elastic inputs and produces elastic outputs, this uses ESI channels.