[MooreToCore] Lower moore.net to llhd.sig #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower `moore.net` operations to the corresponding `llhd.sig`, similar to how `moore.variable` is lowered. This currently only makes sense for "wire" nets, since it's not yet clear how all the other net types map to LLHD.
maerhart
approved these changes
Oct 2, 2024
| return rewriter.notifyMatchFailure(loc, "invalid net type"); | ||
|
|
||
| // TODO: Once the core dialects support four-valued integers, this code | ||
| // will additionally need to generate an all-X value for four-valued nets. |
There was a problem hiding this comment.
Shouldn't it be initialized to all Z once we support four-valued types? I think the standard mentions that as the default value in case there are no drivers.
There was a problem hiding this comment.
That is a good point! I'm also starting to wonder how we'll deal with multiple concurrent drivers on a net. That doesn't easily map to llhd.sig at the moment. It's more like you'd have a list of multiple llhd.sig, one for each driver, and you'd then have a conflict resolution step that merges all the drivers into a final net value. We might need a slightly different lowering in the future 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower
moore.netoperations to the correspondingllhd.sig, similar to howmoore.variableis lowered. This currently only makes sense for "wire" nets, since it's not yet clear how all the other net types map to LLHD.