Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImportVerilog] Add support for elaboration system tasks #7632

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

fabianschuiki
Copy link
Contributor

Simply skip the elaboration system tasks $info, $warning, $error, and $fatal outside procedural code. Slang already processes these tasks and generates the corresponding diagnostics for us.

Simply skip the elaboration system tasks `$info`, `$warning`, `$error`,
and `$fatal` outside procedural code. Slang already processes these
tasks and generates the corresponding diagnostics for us.
Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice that Slang already distinguishes between the elaboration and runtime versions of those!

@fabianschuiki fabianschuiki merged commit ee8e605 into main Sep 25, 2024
4 checks passed
@fabianschuiki fabianschuiki deleted the fschuiki/moore-elaboration-system-tasks branch September 25, 2024 20:11
@hailongSun2000
Copy link
Member

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants